From: "Yan, Zheng" <zheng.z.yan@intel.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
mingo@kernel.org, acme@infradead.org, eranian@google.com
Subject: Re: [PATCH v3 5/9] perf, x86: large PEBS interrupt threshold
Date: Wed, 23 Jul 2014 08:59:03 +0800 [thread overview]
Message-ID: <53CF08D7.7080908@intel.com> (raw)
In-Reply-To: <20140722161617.GQ18735@two.firstfloor.org>
On 07/23/2014 12:16 AM, Andi Kleen wrote:
>> + /*
>> + * When the event is constrained enough we can use a larger
>> + * threshold and run the event with less frequent PMI.
>> + */
>> + if (0 && /* disable this temporarily */
>
> Where in the patchkit does it get reenabled?
enabled by patch 7
>
> -Andi
>
>> + (hwc->flags & PERF_X86_EVENT_AUTO_RELOAD) &&
>> + !(event->attr.sample_type & ~PEBS_FREERUNNING_FLAGS)) {
>> + threshold = ds->pebs_absolute_maximum -
>> + x86_pmu.max_pebs_events * x86_pmu.pebs_record_size;
>> + } else {
>> + threshold = ds->pebs_buffer_base + x86_pmu.pebs_record_size;
>> + }
>> + if (first_pebs || ds->pebs_interrupt_threshold > threshold)
>> + ds->pebs_interrupt_threshold = threshold;
next prev parent reply other threads:[~2014-07-23 0:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 8:09 [PATCH v3 0/7] perf, x86: large PEBS interrupt threshold Yan, Zheng
2014-07-22 8:09 ` [PATCH v3 1/9] perf, core: introduce pmu context switch callback Yan, Zheng
2014-07-22 8:09 ` [PATCH v3 2/9] perf, x86: use context switch callback to flush LBR stack Yan, Zheng
2014-07-22 8:09 ` [PATCH v3 3/9] perf, x86: use the PEBS auto reload mechanism when possible Yan, Zheng
2014-07-22 8:09 ` [PATCH v3 4/9] perf, x86: introduce setup_pebs_sample_data() Yan, Zheng
2014-07-22 8:09 ` [PATCH v3 5/9] perf, x86: large PEBS interrupt threshold Yan, Zheng
2014-07-22 16:16 ` Andi Kleen
2014-07-23 0:59 ` Yan, Zheng [this message]
2014-07-22 8:09 ` [PATCH v3 6/9] perf, x86: handle multiple records in PEBS buffer Yan, Zheng
2014-07-25 8:10 ` Peter Zijlstra
2014-07-25 8:34 ` Yan, Zheng
2014-07-25 14:06 ` Peter Zijlstra
2014-07-28 2:24 ` Yan, Zheng
2014-07-28 3:36 ` Andi Kleen
2014-07-28 6:52 ` Peter Zijlstra
2014-07-31 7:31 ` Yan, Zheng
2014-07-31 14:44 ` Andi Kleen
2014-07-31 15:25 ` Peter Zijlstra
2014-07-25 15:04 ` Andi Kleen
2014-07-25 15:53 ` Peter Zijlstra
2014-07-25 16:40 ` Andi Kleen
2014-07-28 3:20 ` Yan, Zheng
2014-07-28 3:34 ` Andi Kleen
2014-07-28 6:54 ` Peter Zijlstra
2014-07-22 8:10 ` [PATCH v3 7/9] perf, x86: drain PEBS buffer during context switch Yan, Zheng
2014-07-22 8:10 ` [PATCH v3 8/9] perf, x86: enlarge PEBS buffer Yan, Zheng
2014-07-22 8:10 ` [PATCH v3 9/9] tools, perf: Allow the user to disable time stamps Yan, Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CF08D7.7080908@intel.com \
--to=zheng.z.yan@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox