public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Tejun Heo <tj@kernel.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] workqueue: get the probable node ID from the first CPU of the mask
Date: Wed, 23 Jul 2014 09:26:30 +0800	[thread overview]
Message-ID: <53CF0F46.8000508@cn.fujitsu.com> (raw)
In-Reply-To: <20140722153023.GF13851@htj.dyndns.org>

On 07/22/2014 11:30 PM, Tejun Heo wrote:
> On Tue, Jul 22, 2014 at 01:04:02PM +0800, Lai Jiangshan wrote:
>> +		node = cpu_to_node(cpumask_first(pool->attrs->cpumask));
> 
> Minor but maybe cpumask_any() is a better fit here?
> 

It is OK, the result are the same. But I still think cpumask_first() is better since
its name sounds deterministic while we need a deterministic value for pool->node.

Thanks,
Lai

  reply	other threads:[~2014-07-23  1:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22  5:04 [PATCH] workqueue: get the probable node ID from the first CPU of the mask Lai Jiangshan
2014-07-22 15:30 ` Tejun Heo
2014-07-23  1:26   ` Lai Jiangshan [this message]
2014-07-23 15:10     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CF0F46.8000508@cn.fujitsu.com \
    --to=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox