Re: [PATCH 2/4] aio: use the macro rather than the inline magic number

Ming Lei
2014-07-25T03:13:20Z

On Tue, Jul 22, 2014 at 9:54 PM, Jeff Moyer <jmoyer@redhat.com> wrote:
> Gu Zheng <guz.fnst@cn.fujitsu.com> writes:
>
>> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
>
> Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
>
>> ---
>> fs/aio.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/aio.c b/fs/aio.c
>> index ad35876..1dc6158 100644
>> --- a/fs/aio.c
>> +++ b/fs/aio.c
>> @@ -201,7 +201,7 @@ static struct dentry *aio_mount(struct file_system_type *fs_type,
>> static const struct dentry_operations ops = {
>> .d_dname = simple_dname,
>> };
>> - return mount_pseudo(fs_type, "aio:", NULL, &ops, 0xa10a10a1);
>> + return mount_pseudo(fs_type, "aio:", NULL, &ops, AIO_RING_MAGIC);

IMO, it might be better to use a new macro like AIO_FS_MAGIC
with same number here because the same magic number
0xa10a10a1 serves for two purposes.

Thanks,