Re: [PATCH v5 0/3] APEI: Make APEI architecture independent.

[Tomasz Nowicki <tomasz.nowicki@linaro.org>]

Many thanks Tony! And thanks goes to Borislav and Robert too.

Regards,
Tomasz

On 22.07.2014 23:08, Tony Luck wrote:
> On Tue, Jul 22, 2014 at 2:20 AM, Tomasz Nowicki
> <tomasz.nowicki@linaro.org> wrote:
>> APEI is currently implemented so that it depends on x86 hardware.
>> The primary dependency is that GHES uses the x86 NMI for hardware
>> error notification and MCE for memory error handling. These patches
>> remove that dependency.
>>
>> Other APEI features such as error reporting via external IRQ, error
>> serialization, or error injection, do not require changes to use them
>> on non-x86 architectures.
>>
>> The following patch set eliminates the APEI Kconfig x86 dependency
>> by making these changes:
>> - treat NMI notification as GHES architecture - HAVE_ACPI_APEI_NMI
>> - group and wrap around #ifdef CONFIG_HAVE_ACPI_APEI_NMI code which
>>    is used only for NMI path
>> - identify architectural boxes and abstract it accordingly (tlb flush and MCE)
>> - rework ioremap for both IRQ and NMI context
>>
>> NMI code is kept in ghes.c file since NMI and IRQ context are tightly coupled.
>>
>> Note, these patches introduce no functional changes for x86. The NMI notification
>> feature is hard selected for x86. Architectures that want to use this
>> feature should also provide NMI code infrastructure.
>
> Looks OK to me. I've thrown this series into a topic branch of the ras
> git tree named "apei".  When I push it to kernel.org in a few minutes
> the build test robots will pounce and try all sorts of randconfig builds.
> They'll send you (and me) e-mails if they find any corner cases.
>
> -Tony
>