From: Vasily Averin <vvs@parallels.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Richard Weinberger <richard.weinberger@gmail.com>
Subject: Re: [PATCH v4] fs: umount on symlink leaks mnt count
Date: Thu, 24 Jul 2014 09:59:40 +0400 [thread overview]
Message-ID: <53D0A0CC.9070506@parallels.com> (raw)
In-Reply-To: <1406095603.2509.11.camel@perseus.fritz.box>
CVE-2014-5045 was assigned for this issue
On 07/23/2014 10:06 AM, Ian Kent wrote:
> On Mon, 2014-07-21 at 12:30 +0400, Vasily Averin wrote:
>> Currently umount on symlink blocks following umount:
>>
>> /vz is separate mount
>>
>> # ls /vz/ -al | grep test
>> drwxr-xr-x. 2 root root 4096 Jul 19 01:14 testdir
>> lrwxrwxrwx. 1 root root 11 Jul 19 01:16 testlink -> /vz/testdir
>> # umount -l /vz/testlink
>> umount: /vz/testlink: not mounted (expected)
>>
>> # lsof /vz
>> # umount /vz
>> umount: /vz: device is busy. (unexpected)
>>
>> In this case mountpoint_last() gets an extra refcount on path->mnt
>>
>> Signed-off-by: Vasily Averin <vvs@openvz.org>
>
> Acked-by: Ian Kent <raven@themaw.net>
prev parent reply other threads:[~2014-07-24 6:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-20 7:32 [patch v2] fs: umount on symlinlk leaks mnt count Vasily Averin
2014-07-20 10:48 ` Richard Weinberger
[not found] ` <cover.1405859651.git.vvs@openvz.org>
2014-07-20 12:38 ` [PATCH v3] fs: umount on symlink " Vasily Averin
2014-07-21 8:30 ` [PATCH v4] " Vasily Averin
2014-07-21 12:10 ` Jeff Layton
2014-07-23 6:06 ` Ian Kent
2014-07-24 5:59 ` Vasily Averin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D0A0CC.9070506@parallels.com \
--to=vvs@parallels.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.weinberger@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox