From: Thomas Ilsche <thomas.ilsche@tu-dresden.de>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Perf: cannot overide PYTHON(_CONFIG)
Date: Thu, 24 Jul 2014 18:36:09 +0200 [thread overview]
Message-ID: <53D135F9.1070104@tu-dresden.de> (raw)
Dear perf maintainers,
It is documented in Makefile.perf and the Python 3 error message to use
make PYTHON=python2. However this does not work anymore since
9734163b6ee1425c6fa4b65d7e6ce34c9079420d moved the libpython feature check.
Further it would be more portable anyway to use "python2" as default
instead of "python" as long as python3 is not supported. This follows
the PEP 394 recommendation: https://www.python.org/dev/peps/pep-0394
I am not sure how to correctly fix the failure to respect
PYTHON(_CONFIG). I would assume that early in perf/config/Makefile
FEATURE_CHECK_[CFLAGS|LDFLAGS]-libpython(-version) needs to be set
(before the feature checks are executed) and that the reconstruction of
FLAGS_PYTHON_EMBED based on hardcoded python-config needs to be removed.
Best Regards,
Thomas
--
Dipl. Inf. Thomas Ilsche
Computer Scientist
Highly Adaptive Energy-Efficient Computing
CRC 912 HAEC: http://tu-dresden.de/sfb912
Technische Universität Dresden
Center for Information Services and High Performance Computing (ZIH)
01062 Dresden, Germany
Phone: +49 351 463-42168
Fax: +49 351 463-3773
E-Mail: thomas.ilsche@tu-dresden.de
next reply other threads:[~2014-07-24 16:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 16:36 Thomas Ilsche [this message]
2014-07-25 3:14 ` [PATCH 1/2] perf tools: Fix make PYTHON override Namhyung Kim
2014-07-25 3:14 ` [PATCH 2/2] perf tools: Default to python version 2 Namhyung Kim
2014-07-25 9:28 ` Thomas Ilsche
2014-07-25 10:24 ` Namhyung Kim
2014-07-25 11:43 ` Thomas Ilsche
2014-07-28 0:06 ` Namhyung Kim
2014-07-28 11:11 ` Thomas Ilsche
2014-07-29 6:38 ` Namhyung Kim
2014-07-25 7:23 ` [PATCH 1/2] perf tools: Fix make PYTHON override Thomas Ilsche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D135F9.1070104@tu-dresden.de \
--to=thomas.ilsche@tu-dresden.de \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox