Re: [PATCH 2/4] aio: use the macro rather than the inline magic number

Benjamin LaHaise
2014-07-22T14:11:53Z

On Tue, Jul 22, 2014 at 10:40:02AM +0800, Gu Zheng wrote:
> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>

You're missing a commit message here. The patch is otherwise fine.

-ben

> ---
> fs/aio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/aio.c b/fs/aio.c
> index ad35876..1dc6158 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -201,7 +201,7 @@ static struct dentry *aio_mount(struct file_system_type *fs_type,
> static const struct dentry_operations ops = {
> .d_dname = simple_dname,
> };
> - return mount_pseudo(fs_type, "aio:", NULL, &ops, 0xa10a10a1);
> + return mount_pseudo(fs_type, "aio:", NULL, &ops, AIO_RING_MAGIC);
> }
>
> /* aio_setup
> --
> 1.7.7

--
"Thought is the essence of where you are now."