Re: [PATCH v2 07/11] Documentation: devicetree: Fix Xilinx VDMA specification

Michal Simek
2014-07-25T09:40:23Z

[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]

Hi Andreas,

On 07/25/2014 10:46 AM, Andreas Färber wrote:
> Hi Michal,
>
> Am 25.07.2014 09:49, schrieb Michal Simek:
>> On 07/25/2014 01:00 AM, Andreas Färber wrote:
>>> The specification requires xlnx,data-width, but example and driver use
>>> xlnx,datawidth. Change the specification to match the implementation.
>>>
>>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>>> ---
>>> v2: New
>>>
>>> Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
>>> index 1405ed0..e4c4d47 100644
>>> --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
>>> +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
>>> @@ -25,7 +25,7 @@ Required child node properties:
>>> - compatible: It should be either "xlnx,axi-vdma-mm2s-channel" or
>>> "xlnx,axi-vdma-s2mm-channel".
>>> - interrupts: Should contain per channel VDMA interrupts.
>>> -- xlnx,data-width: Should contain the stream data width, take values
>>> +- xlnx,datawidth: Should contain the stream data width, take values
>>> {32,64...1024}.
>
> BTW I just notice that this values specification is ambiguous as to
> whether 96 is a valid value or only powers of 2 like 128. Maybe you want
> to clarify that in a follow-up patch?

really appreciate your help for improving this.
Srikanth T: Can you please look at it?

Thanks,
Michal

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]