linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Jiri Olsa <jolsa@redhat.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: linux-kernel@vger.kernel.org, lttng-dev@lists.lttng.org,
	acme@kernel.org, namhyung.kim@lge.com, tzanussi@gmail.com
Subject: Re: [RFC] perf to ctf converter
Date: Fri, 25 Jul 2014 10:37:16 +0200	[thread overview]
Message-ID: <53D2173C.7090603@linutronix.de> (raw)
In-Reply-To: <20140724144637.GE7652@krava.brq.redhat.com>

On 07/24/2014 04:46 PM, Jiri Olsa wrote:
> hi,

Hi,

> I made some changes over your branch:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
>   perf/ctf_convert
> 
> following patches:
> (needs to be prettyfied, but hopefuly works and ilustrate the point)
>   perf tools: Iterate both common_fields and fields for tracepoit
>   perf tools: Use sample_type for generic fields
> 
> we now add all fields available in the perf.data (via perf_event_attr:sample_type)
> and then for tracepoints we add both common_types and types fields
> 
> I'm not sure we want to store made up data like symbol information,
> which could be obtained from IP anyway - how does babeltrace or any
> other CTF viewer do that?

This is probably for Mathieu best to answer. I *think* that it records
pointers and does not resolve symbols if possible.

I assumed it to be a good thing to do because you don't get the symbols
anymore once the library/binary is upgraded unless you look for the old
files. But then the very same problem you have perf since it does not
record the symbol.
So we could drop the symbol resolution but then we would have to teach
babeltrace and friends to resolve it.

> ---
> However I'm still not convinced 100% this is the way we want
> to go with this. What we do now is:
>   - read/parse perf.data events and convert them into ctf events
> 
> What I/we do originally wanted to do was to use CTF to describe
> perf event as is defined via perf interface, so we dont need to
> parse data stream, but just store it.
> 
> This would be handy/needed for CTF record support, where we _want_
> to store raw data from kernel and not parse it before that.
> 
> I'll recheck and get back with issues I found with this approach.

Okay.

> Meanwhile I think we can continue with what we have now,

Good :)

> I just wanted to share the other approach with you ;-)
> 
> thanks,
> jirka

Sebastian

      reply	other threads:[~2014-07-25  8:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03 16:36 [RFC] perf to ctf converter Sebastian Andrzej Siewior
2014-07-14 14:15 ` Jiri Olsa
2014-07-18 12:34   ` Sebastian Andrzej Siewior
2014-07-18 16:12     ` Sebastian Andrzej Siewior
2014-07-21 15:36     ` Mathieu Desnoyers
2014-08-05 14:51     ` [lttng-dev] " Jérémie Galarneau
2014-08-05 14:57       ` Sebastian Andrzej Siewior
2014-07-21 17:11   ` Sebastian Andrzej Siewior
2014-07-21 18:35     ` Jiri Olsa
2014-07-22  6:58       ` Sebastian Andrzej Siewior
2014-07-22 11:25         ` Jiri Olsa
2014-07-22 11:31           ` Sebastian Andrzej Siewior
2014-07-22 13:31             ` Sebastian Andrzej Siewior
2014-07-24 14:46               ` Jiri Olsa
2014-07-25  8:37                 ` Sebastian Andrzej Siewior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D2173C.7090603@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lttng-dev@lists.lttng.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=namhyung.kim@lge.com \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).