From: Thomas Ilsche <thomas.ilsche@tu-dresden.de>
To: Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH 2/2] perf tools: Default to python version 2
Date: Fri, 25 Jul 2014 11:28:55 +0200 [thread overview]
Message-ID: <53D22357.9010005@tu-dresden.de> (raw)
In-Reply-To: <1406258045-25726-2-git-send-email-namhyung@kernel.org>
Hi Kim,
On 2014-07-25 05:14, Namhyung Kim wrote:
> According to PEP 394 recommendation [1], it's more portable to use
> python2 rather than plain python to refer python binary version 2.
I tried to find out how backwards-compatible this is. python2(-config)
was first available in Python 2.7.3 (April 2012), but it is still not
available in 2.6.9 (Oct. 2013). So it might be better to use python2
as default but fall back to python if python2 is not available.
Best,
Thomas
Signed-off-by: Thomas Ilsche <thomas.ilsche@tu-dresden.de>
---
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index f4f7f58..1b1bc9c 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -117,8 +117,8 @@ ifdef PARSER_DEBUG
endif
ifndef NO_LIBPYTHON
- override PYTHON := \
- $(call get-executable-or-default,PYTHON,python)
+ PYTHON2 := $(call get-executable-or-default,PYTHON,python2)
+ override PYTHON := $(if $(PYTHON2),$(PYTHON2),$(call get-executable,python))
override PYTHON_CONFIG := \
$(call get-executable-or-default,PYTHON_CONFIG,$(PYTHON)-config)
next prev parent reply other threads:[~2014-07-25 9:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 16:36 Perf: cannot overide PYTHON(_CONFIG) Thomas Ilsche
2014-07-25 3:14 ` [PATCH 1/2] perf tools: Fix make PYTHON override Namhyung Kim
2014-07-25 3:14 ` [PATCH 2/2] perf tools: Default to python version 2 Namhyung Kim
2014-07-25 9:28 ` Thomas Ilsche [this message]
2014-07-25 10:24 ` Namhyung Kim
2014-07-25 11:43 ` Thomas Ilsche
2014-07-28 0:06 ` Namhyung Kim
2014-07-28 11:11 ` Thomas Ilsche
2014-07-29 6:38 ` Namhyung Kim
2014-07-25 7:23 ` [PATCH 1/2] perf tools: Fix make PYTHON override Thomas Ilsche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D22357.9010005@tu-dresden.de \
--to=thomas.ilsche@tu-dresden.de \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox