Re: [PATCH v5 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

Nicolin Chen
2014-07-25T11:48:35Z

Hi Varka,

On Fri, Jul 25, 2014 at 05:04:11PM +0530, Varka Bhadram wrote:
> On 07/25/2014 02:16 PM, Nicolin Chen wrote:
> >The Asynchronous Sample Rate Converter (ASRC) converts the sampling rate of a
> >signal associated with an input clock into a signal associated with a different
> >output clock. The driver currently works as a Front End of DPCM with other Back
> >Ends DAI links such as ESAI<->CS42888 and SSI<->WM8962 and SAI. It converts the
> >original sample rate to a common rate supported by Back Ends for playback while
> >converts the common rate of Back Ends to a desired rate for capture. It has 3
> >pairs to support three different substreams within totally 10 channels.
> >
> >Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
> >---
> > .../devicetree/bindings/sound/fsl,asrc.txt | 60 ++
> > sound/soc/fsl/Kconfig | 9 +
> > sound/soc/fsl/Makefile | 2 +
> > sound/soc/fsl/fsl_asrc.c | 992 +++++++++++++++++++++
> > sound/soc/fsl/fsl_asrc.h | 461 ++++++++++
> > sound/soc/fsl/fsl_asrc_dma.c | 386 ++++++++
> > 6 files changed, 1910 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/sound/fsl,asrc.txt
> > create mode 100644 sound/soc/fsl/fsl_asrc.c
> > create mode 100644 sound/soc/fsl/fsl_asrc.h
> > create mode 100644 sound/soc/fsl/fsl_asrc_dma.c
> >
> >
> check patch warnings on this patch...

[...]

./scripts/checkpatch.pl --max-line-length=128 0002-ASoC-fsl_a....patch
total: 0 errors, 0 warnings, 1928 lines checked

0002-ASoC....patch has no obvious style problems and is ready for submission

[...]

I think there's no need to be so strict by wrapping all lines inside
80 characters, especially for those that will be less readable if being
wrapped and for those in header file.

Thank you
Nicolin