From: Tilman Schmidt <tilman@imap.cc>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>,
Hansjoerg Lipp <hjlipp@web.de>
Cc: Karsten Keil <isdn@linux-pingi.de>,
gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: Re: [PATCH] isdn/bas_gigaset: fix a leak on failure path in gigaset_probe()
Date: Sat, 26 Jul 2014 12:23:06 +0200 [thread overview]
Message-ID: <53D3818A.1060401@imap.cc> (raw)
In-Reply-To: <1406327671-28271-1-git-send-email-khoroshilov@ispras.ru>
Am 26.07.2014 00:34, schrieb Alexey Khoroshilov:
> There is a lack of usb_put_dev(udev) on failure path in gigaset_probe().
You're right. Good catch.
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Acked-by: Tilman Schmidt <tilman@imap.cc>
> ---
> drivers/isdn/gigaset/bas-gigaset.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/isdn/gigaset/bas-gigaset.c b/drivers/isdn/gigaset/bas-gigaset.c
> index c44950d3eb7b..b7ae0a0dd5b6 100644
> --- a/drivers/isdn/gigaset/bas-gigaset.c
> +++ b/drivers/isdn/gigaset/bas-gigaset.c
> @@ -2400,6 +2400,7 @@ allocerr:
> error:
> freeurbs(cs);
> usb_set_intfdata(interface, NULL);
> + usb_put_dev(udev);
> gigaset_freecs(cs);
> return rc;
> }
>
--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
next prev parent reply other threads:[~2014-07-26 10:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 22:34 [PATCH] isdn/bas_gigaset: fix a leak on failure path in gigaset_probe() Alexey Khoroshilov
2014-07-26 10:23 ` Tilman Schmidt [this message]
2014-07-29 19:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D3818A.1060401@imap.cc \
--to=tilman@imap.cc \
--cc=gigaset307x-common@lists.sourceforge.net \
--cc=hjlipp@web.de \
--cc=isdn@linux-pingi.de \
--cc=khoroshilov@ispras.ru \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox