From: Jiri Slaby <jslaby@suse.cz>
To: "xinhui.pan" <xinhuix.pan@intel.com>,
Greg KH <gregkh@linuxfoundation.org>
Cc: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
Peter Hurley <peter@hurleysoftware.com>,
mnipxh <mnipxh@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty/n_gsm.c: fix a memory leak in gsmld_open
Date: Mon, 28 Jul 2014 10:49:19 +0200 [thread overview]
Message-ID: <53D60E8F.6080208@suse.cz> (raw)
In-Reply-To: <53D6067C.4000702@intel.com>
On 07/28/2014 10:14 AM, xinhui.pan wrote:
> If gsmld_attach_gsm fails, the gsm is not used anymore.
> tty core will not call gsmld_close to do the cleanup work.
> tty core just restore to the tty old ldisc.
> That always causes memory leak.
Nice catch!
> --- a/drivers/tty/n_gsm.c
> +++ b/drivers/tty/n_gsm.c
> @@ -2382,7 +2383,13 @@ static int gsmld_open(struct tty_struct *tty)
>
> /* Attach the initial passive connection */
> gsm->encoding = 1;
> - return gsmld_attach_gsm(tty, gsm);
> +
> + ret = gsmld_attach_gsm(tty, gsm);
> + if (ret != 0) {
> + gsm_cleanup_mux(gsm);
> + mux_put(gsm);
It is quite illogical to put the mux here. It should be in gsmld_open.
I.e. gsm_cleanup_mux here, mux_put there.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2014-07-28 8:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 8:14 [PATCH] tty/n_gsm.c: fix a memory leak in gsmld_open xinhui.pan
2014-07-28 8:23 ` xinhui.pan
2014-07-28 8:49 ` Jiri Slaby [this message]
2014-07-28 9:03 ` xinhui.pan
2014-07-28 11:32 ` xinhui.pan
2014-07-28 12:11 ` Jiri Slaby
2014-07-28 19:30 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D60E8F.6080208@suse.cz \
--to=jslaby@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mnipxh@gmail.com \
--cc=peter@hurleysoftware.com \
--cc=xinhuix.pan@intel.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox