From: Chanwoo Choi <cw00.choi@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org, jic23@kernel.org,
devicetree@vger.kernel.org, kgene.kim@samsung.com,
linux-doc@vger.kernel.org, linux-iio@vger.kernel.org,
t.figa@samsung.com, linux-kernel@vger.kernel.org,
kyungmin.park@samsung.com, linux-samsung-soc@vger.kernel.org,
ch.naveen@samsung.com
Subject: Re: [PATCH 2/2] iio: adc: exynos_adc: Add support for S3C24xx ADC
Date: Mon, 28 Jul 2014 20:18:02 +0900 [thread overview]
Message-ID: <53D6316A.2010007@samsung.com> (raw)
In-Reply-To: <5954793.q4YDWmuNDB@wuerfel>
On 07/22/2014 09:59 PM, Arnd Bergmann wrote:
> On Tuesday 22 July 2014 11:11:14 Chanwoo Choi wrote:
>> This patch add support for s3c2410/s3c2416/s3c2440/s3c2443 ADC. The s3c24xx
>> is alomost same as ADCv1. But, There are a little difference as following:
>> - ADCMUX register address to select channel
>> - ADCDAT mask (10bit or 12bit ADC resolution according to SoC version)
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>
> While looking at the driver again to see if the touchscreen patch needs
> an update for this, I noticed that the s3c24xx variants don't have the
> ADC_V1_INTCLR and ADC_V1_CLRINTPNDNUP registers, so I assume your patch
> will have to be updated not to acknowledge the interrupts.
>
> It's possible that writing to the missing registers is harmless though and
> that you don't need that change.
OK, I'll remove the function pointer of clear_irq for s3c24xx.
Best Regards,
Chanwoo Choi
next prev parent reply other threads:[~2014-07-28 11:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 2:11 [PATCH 0/2] iio: adc: exynos_adc: Add support for s3c64xx/s3c24xx ADC Chanwoo Choi
2014-07-22 2:11 ` [PATCH 1/2] iio: adc: exynos_adc: add support for s3c64xx adc Chanwoo Choi
2014-07-27 18:49 ` Hartmut Knaack
2014-07-28 11:18 ` Chanwoo Choi
2014-07-22 2:11 ` [PATCH 2/2] iio: adc: exynos_adc: Add support for S3C24xx ADC Chanwoo Choi
2014-07-22 8:39 ` Arnd Bergmann
2014-07-22 10:44 ` Heiko Stübner
2014-07-28 12:08 ` Chanwoo Choi
2014-07-28 11:20 ` Chanwoo Choi
2014-07-22 12:59 ` Arnd Bergmann
2014-07-28 11:18 ` Chanwoo Choi [this message]
2014-07-27 20:35 ` Hartmut Knaack
2014-07-28 11:03 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D6316A.2010007@samsung.com \
--to=cw00.choi@samsung.com \
--cc=arnd@arndb.de \
--cc=ch.naveen@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox