From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752694AbaG1MIj (ORCPT ); Mon, 28 Jul 2014 08:08:39 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:35527 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751674AbaG1MIb convert rfc822-to-8bit (ORCPT ); Mon, 28 Jul 2014 08:08:31 -0400 X-AuditID: cbfee68f-b7fa26d0000039a0-bb-53d63d3c414c MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 8BIT Message-id: <53D63D3C.7000401@samsung.com> Date: Mon, 28 Jul 2014 21:08:28 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 To: =?ISO-8859-1?Q?Heiko_St=FCbner?= Cc: Arnd Bergmann , jic23@kernel.org, ch.naveen@samsung.com, kgene.kim@samsung.com, kyungmin.park@samsung.com, t.figa@samsung.com, linux-iio@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH 2/2] iio: adc: exynos_adc: Add support for S3C24xx ADC References: <1405995074-3271-1-git-send-email-cw00.choi@samsung.com> <1405995074-3271-3-git-send-email-cw00.choi@samsung.com> <5200888.DXoC06U953@wuerfel> <175757227.TPQdXAQiJt@diego> In-reply-to: <175757227.TPQdXAQiJt@diego> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBIsWRmVeSWpSXmKPExsWyRsSkRNfG9lqwwdqtNhZ/Jx1jt7j7/DCj xfwj51gt/j96zWrxoGkVk0XvgqtsFmeb3rBbbHp8jdViYdsSFot5R96xWFzeNYfNYsb5fUwW 62e8ZnHg9fj9axKjx6ZVnWwem5fUe/RtWcXosf3aPGaPz5vkAtiiuGxSUnMyy1KL9O0SuDKW b13AVPBKqGJRyzu2Bsa1fF2MnBwSAiYSm/9OYYSwxSQu3FvPBmILCSxllNjXadXFyAFWM+lh VBcjF1B4OqNE69P/TCA1vAKCEj8m32MBsZkFdCT2t05jg7BFJLY2P2SEsLUlli18zQzR/JpR 4v2umWwQzVoSJ09dBStiEVCVOLnmENggNqD4/hc3wGpEBcIkVk6/AhYXETCTuHW1DWwQs8BF JolnK3+xgiSEBbwkLrZeYIPYsJtRovPucVaQszkFNCUuvSgAiUsItHJI3P/5jxVim4DEt8kg 20Bek5XYdIAZ4ntJiYMrbrBMYBSfheS5WUiem4XkuVlInlvAyLKKUTS1ILmgOCm9yFivODG3 uDQvXS85P3cTIzDWT/971r+D8e4B60OMyUDrJzJLiSbnA1NFXkm8obGZkYWpiamxkbmlGWnC SuK89x8mBQkJpCeWpGanphakFsUXleakFh9iZOLglGpgFPj+QvJd/OqMLlFzIVebGHFNn8pJ 0pe5zNmuXpxhZZtSO3Gz4iztHyqWjfNv7rDPUH2vu6zU87qRh8y7I+FuPOfYOMKFO42mdCrJ Jyrd65W9XH799cFzPSJ2Gb2GsyeEmh5x6jHoqznyfsLvwxXXvS/X/rOWkhETOWs24ZXy3o7N 2YdnBvArsRRnJBpqMRcVJwIA/OEU5QsDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42I5/e+xoK6N7bVgg7VfjS3+TjrGbnH3+WFG i/lHzrFa/H/0mtXiQdMqJoveBVfZLM42vWG32PT4GqvFwrYlLBbzjrxjsbi8aw6bxYzz+5gs 1s94zeLA6/H71yRGj02rOtk8Ni+p9+jbsorRY/u1ecwenzfJBbBFNTDaZKQmpqQWKaTmJeen ZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gBdqqRQlphTChQKSCwuVtK3wzQh NMRN1wKmMULXNyQIrsfIAA0krGHMuHF0JXPBA6GKC43rmRsYF/N1MXJwSAiYSEx6GNXFyAlk iklcuLeerYuRi0NIYDqjROvT/0wgCV4BQYkfk++xgNQzC8hLHLmUDRJmFtCR2N86Dar+NaPE +10z2SDqtSROnrrKCGKzCKhKnFxziAXEZgOK739xA6xGVCBMYuX0K2BxEQEziVtX25hBBjEL XGSSeLbyFytIQljAS+Ji6wWoDbsZJTrvHmcFuYJTQFPi0ouCCYwCs5DcNwvhvllI7lvAyLyK UTS1ILmgOCk910ivODG3uDQvXS85P3cTIzgtPJPewbiqweIQowAHoxIPr0Xw1WAh1sSy4src Q4wSHMxKIrxT9a8FC/GmJFZWpRblxxeV5qQWH2I0BfpuIrOUaHI+MGXllcQbGpuYGVkamRta GBmbK4nzHmy1DhQSSE8sSc1OTS1ILYLpY+LglGpgXOLMFXFZ2zp4kbfztM54ZpNVm5MqGhZs UNF68FtVT+DX1vSmDz2bXY58kHnGxPp9Uajxi+hVjDVVz8PDHPdfvlmf9H3un38ftkscPc5U 6N5+9qfS86U9X8Vzz7HFCol8vHdUbpWV8gK58FXM2nv//s6delV2+uV5a2UcNSYual7Q7GDS euUppxJLcUaioRZzUXEiAMfIjGYhAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/22/2014 07:44 PM, Heiko Stübner wrote: > Am Dienstag, 22. Juli 2014, 10:39:38 schrieb Arnd Bergmann: >> On Tuesday 22 July 2014 11:11:14 Chanwoo Choi wrote: >>> This patch add support for s3c2410/s3c2416/s3c2440/s3c2443 ADC. The >>> s3c24xx >>> is alomost same as ADCv1. But, There are a little difference as following: >>> - ADCMUX register address to select channel >>> - ADCDAT mask (10bit or 12bit ADC resolution according to SoC version) >> >> Very good, thanks for doing this patch! >> >> (adding Heiko to Cc, he's probably interested in seeing this as well. > > indeed. Thanks for implementing this. > > While trying to build a test setup for this, I noticed two points: > > (1) I'm not sure what the second register (a "phy enable register" according > to the binding) is supposed to be. > According to binding and adc code it is mandatory, but I didn't find any > lone adc register in the s3c2416 manual. You're right. I don't find ADC_PHY_CONTROL register on s3c2410 datasheet. So, if 'needs_adc_phy' field is true, exynos-adc would only get 'phy enable register' from dt node. - mem = platform_get_resource(pdev, IORESOURCE_MEM, 1); - info->enable_reg = devm_ioremap_resource(&pdev->dev, mem); - if (IS_ERR(info->enable_reg)) - return PTR_ERR(info->enable_reg); + + if (info->data->needs_adc_phy) { + mem = platform_get_resource(pdev, IORESOURCE_MEM, 1); + info->enable_reg = devm_ioremap_resource(&pdev->dev, mem); + if (IS_ERR(info->enable_reg)) + return PTR_ERR(info->enable_reg); + } > > > (2) You might need something along the lines of: > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index 11b048a..088c99a 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -129,7 +129,7 @@ config AT91_ADC > > config EXYNOS_ADC > tristate "Exynos ADC driver support" > - depends on ARCH_EXYNOS || (OF && COMPILE_TEST) > + depends on ARCH_EXYNOS || ARCH_S3C24XX || ARCH_S3C64XX || (OF && COMPILE_TEST) > help > Core support for the ADC block found in the Samsung EXYNOS series > of SoCs for drivers such as the touchscreen and hwmon to use to share OK, I'll modify it as your comment. Best Regards, Chanwoo Choi