From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: Mike Qiu <qiudayu@linux.vnet.ibm.com>, <cgroups@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: WARNING: at kernel/cpuset.c:1139
Date: Tue, 29 Jul 2014 17:07:30 +0800 [thread overview]
Message-ID: <53D76452.10206@huawei.com> (raw)
In-Reply-To: <20140728192026.GI7462@htj.dyndns.org>
On 2014/7/29 3:20, Tejun Heo wrote:
> On Thu, Jul 24, 2014 at 08:27:40AM +0800, Li Zefan wrote:
>> On 2014/7/23 23:12, Tejun Heo wrote:
>>> On Wed, Jul 23, 2014 at 10:50:29AM +0800, Mike Qiu wrote:
>>>> commit 734d45130cb ("cpuset: update cs->effective_{cpus, mems} when config
>>>> changes") introduce the below warning in my server.
>>>>
>>>> [ 35.652137] ------------[ cut here ]------------
>>>> [ 35.652141] WARNING: at kernel/cpuset.c:1139
>>>
>>> Hah, can you reproduce it? If so, can you detail how?
>>>
>>
>> It's a typo.
>>
>> WARN_ON(!cgroup_on_dfl(cp->css.cgroup) &&
>> nodes_equal(cp->mems_allowed, cp->effective_mems));
>>
>> should be
>>
>> WARN_ON(!cgroup_on_dfl(cp->css.cgroup) &&
>> !nodes_equal(cp->mems_allowed, cp->effective_mems));
>
> Care to post a patch?
>
Sorry for the delay. I had been off office for the last two weeks.
I'll do this tomorrow.
prev parent reply other threads:[~2014-07-29 9:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 2:50 WARNING: at kernel/cpuset.c:1139 Mike Qiu
2014-07-23 15:12 ` Tejun Heo
2014-07-24 0:27 ` Li Zefan
2014-07-24 2:46 ` Mike Qiu
2014-07-28 19:20 ` Tejun Heo
2014-07-29 9:07 ` Li Zefan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D76452.10206@huawei.com \
--to=lizefan@huawei.com \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiudayu@linux.vnet.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox