From: Rik van Riel <riel@redhat.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Michael Neuling <mikey@neuling.org>,
Ingo Molnar <mingo@kernel.org>,
jhladky@redhat.com, ktkhai@parallels.com,
tim.c.chen@linux.intel.com,
Nicolas Pitre <nicolas.pitre@linaro.org>
Subject: Re: [PATCH 1/2] sched: fix and clean up calculate_imbalance
Date: Tue, 29 Jul 2014 11:39:07 -0400 [thread overview]
Message-ID: <53D7C01B.9060801@redhat.com> (raw)
In-Reply-To: <CAKfTPtAS-0-9duQgXtri9WxYgFxoKbE05z+4HysCCOS6OaocMQ@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 07/29/2014 11:31 AM, Vincent Guittot wrote:
> On 29 July 2014 16:53, Rik van Riel <riel@redhat.com> wrote:
>> I cannot think of any case where keeping the "overloaded" code
>> would result in the code behaving differently over the long
>> term.
>
>> What am I overlooking?
>
> IIUC the load_above_capacity is there to prevent the busiest group
> to become idle and you remove that protection
Having the busiest group become partially idle is perfectly fine,
as long as there is also spare capacity in the destination group.
Spreading out the work load over more CPU sockets, with more CPU
cache and more total available memory bandwidth is often a good
thing.
- --
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJT18AbAAoJEM553pKExN6DaLoH/RzCR/YWDYe4/tZEC/sHn89l
jCOVdoY2ZkVHx/yO1Vd0UeoAE94XFsiw0sKwy0lVXLxi3nBIjfh41qZkGoS2lQuo
YSi7PE2o6T5WmluEQfTnUn1DAX0sigUYvWAxnpDYM6I+m8RS0QB7VYSaoqaT3T8D
qomO8FmBN75JrwoywWBDiVRjnxfQJzt6bBK92GUIo6+af6RUSQ9xwQg6EPp3E3r6
FFqIHJ6HaRFCml1KMD4azopVC/bbbhvnbE/EO/5In2nbBsVK06XpBlLWfCyiD48q
NkjnAjISweWTCoMdhULaXdLGeWH85DWoDtvDTCbK+m/QBXRXdiAbij0fDFDhPck=
=QIq6
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-07-29 15:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 18:16 [PATCH 0/2] load balancing fixes riel
2014-07-28 18:16 ` [PATCH 1/2] sched: fix and clean up calculate_imbalance riel
2014-07-29 9:04 ` Vincent Guittot
2014-07-29 14:53 ` Rik van Riel
2014-07-29 15:31 ` Vincent Guittot
2014-07-29 15:39 ` Rik van Riel [this message]
2014-07-29 14:59 ` Peter Zijlstra
2014-07-29 15:15 ` Rik van Riel
2014-07-29 15:49 ` Peter Zijlstra
2014-07-29 17:04 ` Rik van Riel
2014-07-29 15:27 ` Peter Zijlstra
2014-07-30 9:32 ` Vincent Guittot
2014-07-30 10:13 ` Peter Zijlstra
2014-08-12 14:52 ` [tip:sched/core] sched/fair: Allow calculate_imbalance() to move idle cpus tip-bot for Peter Zijlstra
2014-07-29 14:49 ` [PATCH 1/2] sched: fix and clean up calculate_imbalance Peter Zijlstra
2014-07-29 14:53 ` Peter Zijlstra
2014-07-29 15:26 ` Peter Zijlstra
2014-08-12 14:52 ` [tip:sched/core] sched/fair: Make calculate_imbalance() independent tip-bot for Peter Zijlstra
2014-07-28 18:16 ` [PATCH 2/2] sched: make update_sd_pick_busiest return true on a busier sd riel
2014-07-29 15:27 ` Peter Zijlstra
2014-08-12 14:52 ` [tip:sched/core] sched/fair: Make update_sd_pick_busiest() return 'true' " tip-bot for Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D7C01B.9060801@redhat.com \
--to=riel@redhat.com \
--cc=jhladky@redhat.com \
--cc=ktkhai@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikey@neuling.org \
--cc=mingo@kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=peterz@infradead.org \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox