public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Josh Wu <josh.wu@atmel.com>
To: Raphael Poggi <poggi.raph@gmail.com>, <dwmw2@infradead.org>,
	<computersforpeace@gmail.com>, <linux-mtd@lists.infradead.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: atmel_nand: increase chip_delay
Date: Wed, 30 Jul 2014 17:36:18 +0800	[thread overview]
Message-ID: <53D8BC92.4050907@atmel.com> (raw)
In-Reply-To: <1406640447-9080-1-git-send-email-poggi.raph@gmail.com>

Hi, Raphael

On 7/29/2014 9:27 PM, Raphael Poggi wrote:
> Some nand with 8k page size like Micron MT29F32G08ABAAAWP need more than 20us.
>
> Signed-off-by: Raphaël Poggi <poggi.raph@gmail.com>
> ---
>   drivers/mtd/nand/atmel_nand.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index e321c56..77bd877 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -2099,7 +2099,7 @@ static int atmel_nand_probe(struct platform_device *pdev)
>   	}
>   
>   	nand_chip->ecc.mode = host->board.ecc_mode;
> -	nand_chip->chip_delay = 20;		/* 20us command delay time */
> +	nand_chip->chip_delay = 40;		/* 40us command delay time */
>   
>   	if (host->board.bus_width_16)	/* 16-bit bus width */
>   		nand_chip->options |= NAND_BUSWIDTH_16;

I just post a patch [1] days ago which does almost the same thing to 
support 4k-page nand flash.
personally I am fine with your patch.

Brain, you only need to take care this patch. And drop my patch [1].

[1] http://patchwork.ozlabs.org/patch/372406/

Thanks.
Best Regards,
Josh Wu



  reply	other threads:[~2014-07-30  9:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-29 13:27 [PATCH] mtd: atmel_nand: increase chip_delay Raphael Poggi
2014-07-30  9:36 ` Josh Wu [this message]
2014-08-04 21:17   ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D8BC92.4050907@atmel.com \
    --to=josh.wu@atmel.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=poggi.raph@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox