* [PATCH] mtd: atmel_nand: increase chip_delay
@ 2014-07-29 13:27 Raphael Poggi
2014-07-30 9:36 ` Josh Wu
0 siblings, 1 reply; 3+ messages in thread
From: Raphael Poggi @ 2014-07-29 13:27 UTC (permalink / raw)
To: dwmw2, computersforpeace, linux-mtd; +Cc: linux-kernel, Raphael Poggi
Some nand with 8k page size like Micron MT29F32G08ABAAAWP need more than 20us.
Signed-off-by: Raphaël Poggi <poggi.raph@gmail.com>
---
drivers/mtd/nand/atmel_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index e321c56..77bd877 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -2099,7 +2099,7 @@ static int atmel_nand_probe(struct platform_device *pdev)
}
nand_chip->ecc.mode = host->board.ecc_mode;
- nand_chip->chip_delay = 20; /* 20us command delay time */
+ nand_chip->chip_delay = 40; /* 40us command delay time */
if (host->board.bus_width_16) /* 16-bit bus width */
nand_chip->options |= NAND_BUSWIDTH_16;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: atmel_nand: increase chip_delay
2014-07-29 13:27 [PATCH] mtd: atmel_nand: increase chip_delay Raphael Poggi
@ 2014-07-30 9:36 ` Josh Wu
2014-08-04 21:17 ` Brian Norris
0 siblings, 1 reply; 3+ messages in thread
From: Josh Wu @ 2014-07-30 9:36 UTC (permalink / raw)
To: Raphael Poggi, dwmw2, computersforpeace, linux-mtd; +Cc: linux-kernel
Hi, Raphael
On 7/29/2014 9:27 PM, Raphael Poggi wrote:
> Some nand with 8k page size like Micron MT29F32G08ABAAAWP need more than 20us.
>
> Signed-off-by: Raphaël Poggi <poggi.raph@gmail.com>
> ---
> drivers/mtd/nand/atmel_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index e321c56..77bd877 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -2099,7 +2099,7 @@ static int atmel_nand_probe(struct platform_device *pdev)
> }
>
> nand_chip->ecc.mode = host->board.ecc_mode;
> - nand_chip->chip_delay = 20; /* 20us command delay time */
> + nand_chip->chip_delay = 40; /* 40us command delay time */
>
> if (host->board.bus_width_16) /* 16-bit bus width */
> nand_chip->options |= NAND_BUSWIDTH_16;
I just post a patch [1] days ago which does almost the same thing to
support 4k-page nand flash.
personally I am fine with your patch.
Brain, you only need to take care this patch. And drop my patch [1].
[1] http://patchwork.ozlabs.org/patch/372406/
Thanks.
Best Regards,
Josh Wu
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: atmel_nand: increase chip_delay
2014-07-30 9:36 ` Josh Wu
@ 2014-08-04 21:17 ` Brian Norris
0 siblings, 0 replies; 3+ messages in thread
From: Brian Norris @ 2014-08-04 21:17 UTC (permalink / raw)
To: Josh Wu; +Cc: Raphael Poggi, dwmw2, linux-mtd, linux-kernel
On Wed, Jul 30, 2014 at 05:36:18PM +0800, Josh Wu wrote:
> On 7/29/2014 9:27 PM, Raphael Poggi wrote:
> >Some nand with 8k page size like Micron MT29F32G08ABAAAWP need more than 20us.
> >
> >Signed-off-by: Raphaël Poggi <poggi.raph@gmail.com>
> >---
> > drivers/mtd/nand/atmel_nand.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> >index e321c56..77bd877 100644
> >--- a/drivers/mtd/nand/atmel_nand.c
> >+++ b/drivers/mtd/nand/atmel_nand.c
> >@@ -2099,7 +2099,7 @@ static int atmel_nand_probe(struct platform_device *pdev)
> > }
> > nand_chip->ecc.mode = host->board.ecc_mode;
> >- nand_chip->chip_delay = 20; /* 20us command delay time */
> >+ nand_chip->chip_delay = 40; /* 40us command delay time */
> > if (host->board.bus_width_16) /* 16-bit bus width */
> > nand_chip->options |= NAND_BUSWIDTH_16;
>
> I just post a patch [1] days ago which does almost the same thing to
> support 4k-page nand flash.
> personally I am fine with your patch.
>
> Brain, you only need to take care this patch. And drop my patch [1].
>
> [1] http://patchwork.ozlabs.org/patch/372406/
OK, queued to l2-mtd.git/next. Thanks!
Brian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-04 21:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-29 13:27 [PATCH] mtd: atmel_nand: increase chip_delay Raphael Poggi
2014-07-30 9:36 ` Josh Wu
2014-08-04 21:17 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox