RE: [PATCH 00/19] staging: comedi: amplc_pci230: tidy up a bit

Hartley Sweeten
2014-07-30T00:54:22Z

On Tuesday, July 29, 2014 4:58 AM, Ian Abbott wrote:
>
> Tidy up the "amplc_pci230" driver a bit. There are more changes to come
> after this. The only one of these that should alter the object code is
> patch 06, which replaces a udelay() call with usleep_range().
>
> 01) staging: comedi: amplc_pci230: reformat a load of comments
> 02) staging: comedi: amplc_pci230: fix checkpatch line over 80
> characters
> 03) staging: comedi: amplc_pci230: logical continuations should be on
> the previous line
> 04) staging: comedi: amplc_pci230: blank lines aren't necessary before a
> close brace '}'
> 05) staging: comedi: amplc_pci230: alignment should match open
> parenthesis
> 06) staging: comedi: amplc_pci230: usleep_range is preferred over udelay
> 07) staging: comedi: amplc_pci230: remove unused settling time constants
> 08) staging: comedi: amplc_pci230: remove PCI230_ADC_CONV
> 09) staging: comedi: amplc_pci230: remove PCI230_TEST_BIT()
> 10) staging: comedi: amplc_pci230: add whitespace to register values
> 11) staging: comedi: amplc_pci230: don't begin line with binary operator
> 12) staging: comedi: amplc_pci230: omit '!= 0' from logical expressions
> 13) staging: comedi: amplc_pci230: remove unnecessary braces
> 14) staging: comedi: amplc_pci230: remove some indentation in
> pci230_ai_check_chanlist()
> 15) staging: comedi: amplc_pci230: no need for '&function'
> 16) staging: comedi: amplc_pci230: add whitespace to pci230_boards[]
> 17) staging: comedi: amplc_pci230: no need to initialize named members
> to zero
> 18) staging: comedi: amplc_pci230: tidy up stuct pci230_private
> 19) staging: comedi: amplc_pci230: remove some unnecessary parentheses
>
> drivers/staging/comedi/drivers/amplc_pci230.c | 1417 +++++++++++++------------
> 1 file changed, 736 insertions(+), 681 deletions(-)

Other than my comment about patch 13, this looks ok.

Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>