From: Colin Ian King <colin.king@canonical.com>
To: Matt Fleming <matt@console-pimps.org>, Borislav Petkov <bp@alien8.de>
Cc: Prarit Bhargava <prarit@redhat.com>,
linux-kernel@vger.kernel.org, lszubowi@redhat.com,
Matt Fleming <matt.fleming@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-efi@vger.kernel.org
Subject: Re: [PATCH] x86, efi: print debug values in Kib not MB
Date: Wed, 30 Jul 2014 16:05:39 +0100 [thread overview]
Message-ID: <53D909C3.9050205@canonical.com> (raw)
In-Reply-To: <20140730144803.GB15082@console-pimps.org>
On 30/07/14 15:48, Matt Fleming wrote:
> On Wed, 30 Jul, at 12:29:32AM, Borislav Petkov wrote:
>> On Tue, Jul 29, 2014 at 01:09:21PM -0400, Prarit Bhargava wrote:
>>> The current debug print in EFI does
>>>
>>> [ 0.000000] efi: mem84: type=3, attr=0xf, range=[0x00000000645b5000-0x00000000645fb000) (0MB)
>>>
>>> and rounds off the size to 0MB and isn't very useful. We should print this in
>>> Kib. After applying this patch we get better info with
>>>
>>> [ 0.000000] efi: mem84: type=3, attr=0xf, range=[0x00000000645b5000-0x00000000645fb000) (280kiB)
>>
>> Turning this into kiB unconditionally won't always work ok:
>>
>> First of all, there might be something which parses that output so I'd
>> make sure I'm not breaking that. Maybe fwts... Matt will know.
>
> I'm not aware of anything that parses the dmesg output, but I'm
> including Colin in case he has any insight.
>
That won't break fwts.
Colin
next prev parent reply other threads:[~2014-07-30 15:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 17:09 [PATCH] x86, efi: print debug values in Kib not MB Prarit Bhargava
2014-07-29 20:29 ` David Rientjes
2014-07-29 22:02 ` Joe Perches
2014-07-29 22:05 ` Prarit Bhargava
2014-07-29 22:05 ` Prarit Bhargava
2014-07-29 22:29 ` Borislav Petkov
2014-07-29 22:32 ` Prarit Bhargava
2014-07-29 22:36 ` Borislav Petkov
2014-07-29 22:42 ` David Rientjes
2014-07-29 23:01 ` Borislav Petkov
2014-07-29 23:03 ` Prarit Bhargava
2014-07-29 23:07 ` Joe Perches
2014-07-29 23:44 ` David Rientjes
2014-07-29 22:54 ` Prarit Bhargava
2014-07-30 3:25 ` Steven Noonan
2014-07-30 14:48 ` Matt Fleming
2014-07-30 15:05 ` Colin Ian King [this message]
2014-07-30 17:04 ` Prarit Bhargava
2014-07-30 17:10 ` Randy Dunlap
2014-07-30 17:21 ` H. Peter Anvin
2014-07-30 19:58 ` Borislav Petkov
2014-07-30 20:43 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D909C3.9050205@canonical.com \
--to=colin.king@canonical.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lszubowi@redhat.com \
--cc=matt.fleming@intel.com \
--cc=matt@console-pimps.org \
--cc=mingo@redhat.com \
--cc=prarit@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox