From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755207AbaG3RFB (ORCPT ); Wed, 30 Jul 2014 13:05:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32093 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754454AbaG3RE7 (ORCPT ); Wed, 30 Jul 2014 13:04:59 -0400 Message-ID: <53D9259F.5050307@redhat.com> Date: Wed, 30 Jul 2014 13:04:31 -0400 From: Prarit Bhargava User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131028 Thunderbird/17.0.10 MIME-Version: 1.0 To: Matt Fleming CC: Colin Ian King , Borislav Petkov , linux-kernel@vger.kernel.org, lszubowi@redhat.com, Matt Fleming , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-efi@vger.kernel.org Subject: Re: [PATCH] x86, efi: print debug values in Kib not MB References: <1406653761-3884-1-git-send-email-prarit@redhat.com> <20140729222932.GA17481@pd.tnic> <20140730144803.GB15082@console-pimps.org> <53D909C3.9050205@canonical.com> In-Reply-To: <53D909C3.9050205@canonical.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/30/2014 11:05 AM, Colin Ian King wrote: > On 30/07/14 15:48, Matt Fleming wrote: >> On Wed, 30 Jul, at 12:29:32AM, Borislav Petkov wrote: >>> On Tue, Jul 29, 2014 at 01:09:21PM -0400, Prarit Bhargava wrote: >>>> The current debug print in EFI does >>>> >>>> [ 0.000000] efi: mem84: type=3, attr=0xf, range=[0x00000000645b5000-0x00000000645fb000) (0MB) >>>> >>>> and rounds off the size to 0MB and isn't very useful. We should print this in >>>> Kib. After applying this patch we get better info with >>>> >>>> [ 0.000000] efi: mem84: type=3, attr=0xf, range=[0x00000000645b5000-0x00000000645fb000) (280kiB) >>> >>> Turning this into kiB unconditionally won't always work ok: >>> >>> First of all, there might be something which parses that output so I'd >>> make sure I'm not breaking that. Maybe fwts... Matt will know. >> >> I'm not aware of anything that parses the dmesg output, but I'm >> including Colin in case he has any insight. >> > That won't break fwts. Matt -- could you make a decision on whether or not this should be strictly in KiB or if it should be a rolling KiB, Mib, and GiB? My issue is simply that I'd like to know *exactly* how big each range is and not have it rounded off. Others think that it is easier to read Mib & Gib ... P. > > Colin >