From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752049AbaGaQbn (ORCPT <rfc822;w@1wt.eu>);
	Thu, 31 Jul 2014 12:31:43 -0400
Received: from casper.infradead.org ([85.118.1.10]:48991 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751316AbaGaQbm (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 31 Jul 2014 12:31:42 -0400
Message-ID: <53DA6F69.5050500@infradead.org>
Date: Thu, 31 Jul 2014 09:31:37 -0700
From: Randy Dunlap <rdunlap@infradead.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: Arjun Sreedharan <arjun024@gmail.com>, rjw@rjwysocki.net
CC: lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        joe@perches.com
Subject: Re: [PATCH] Replace faulty is_hex_digit() by isxdigit()
References: <53D9895A.1030902@infradead.org> <1406797489-4296-1-git-send-email-arjun024@gmail.com>
In-Reply-To: <1406797489-4296-1-git-send-email-arjun024@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/31/14 02:04, Arjun Sreedharan wrote:
> 0 is ascii for NULL. Hex digit matching should be from '0'.
> Faulty version returns true for #,$,%,& etc.
> 
> Signed-off-by: Arjun Sreedharan <arjun024@gmail.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  drivers/acpi/acpi_pnp.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c
> index 4ddb0dc..996fa19 100644
> --- a/drivers/acpi/acpi_pnp.c
> +++ b/drivers/acpi/acpi_pnp.c
> @@ -12,6 +12,7 @@
>  
>  #include <linux/acpi.h>
>  #include <linux/module.h>
> +#include <linux/ctype.h>
>  
>  static const struct acpi_device_id acpi_pnp_device_ids[] = {
>  	/* soc_button_array */
> @@ -320,11 +321,6 @@ static const struct acpi_device_id acpi_pnp_device_ids[] = {
>  	{""},
>  };
>  
> -static bool is_hex_digit(char c)
> -{
> -	return (c >= 0 && c <= '9') || (c >= 'A' && c <= 'F');
> -}
> -
>  static bool matching_id(char *idstr, char *list_id)
>  {
>  	int i;
> @@ -335,7 +331,7 @@ static bool matching_id(char *idstr, char *list_id)
>  	for (i = 3; i < 7; i++) {
>  		char c = toupper(idstr[i]);
>  
> -		if (!is_hex_digit(c)
> +		if (!isxdigit(c)
>  		    || (list_id[i] != 'X' && c != toupper(list_id[i])))
>  			return false;
>  	}
> 


-- 
~Randy