From: Chris Metcalf <cmetcalf@tilera.com>
To: Pawel Moll <pawel.moll@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Olof Johansson <olof@lixom.net>,
Stephen Warren <swarren@wwwdotorg.org>,
Catalin Marinas <Catalin.Marinas@arm.com>, <paul@pwsan.com>,
Arnd Bergmann <arnd@arndb.de>,
Peter De Schrijver <pdeschrijver@nvidia.com>, <arm@kernel.org>,
<linux-tegra@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] char: tile-srom: Remove reference to platform_bus
Date: Thu, 31 Jul 2014 16:24:37 -0400 [thread overview]
Message-ID: <53DAA605.2030500@tilera.com> (raw)
In-Reply-To: <1406298233-27876-2-git-send-email-pawel.moll@arm.com>
On 7/25/2014 10:23 AM, Pawel Moll wrote:
> The code was creating "srom" class devices using
> platform_bus as a parent. As they are not really
> platform devices, make them virtual, using NULL instead.
>
> Cc: Chris Metcalf<cmetcalf@tilera.com>
> Signed-off-by: Pawel Moll<pawel.moll@arm.com>
> ---
> drivers/char/tile-srom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Can you clarify the point of this change a bit? The SROM devices
in question are real devices (bits of silicon on the processor die), not
some kind of virtual construct. In addition, we also have user binaries
in the wild that know to look for /sys/devices/platform/srom/ paths,
so I'm pretty reluctant to change this path without good reason.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
next prev parent reply other threads:[~2014-07-31 20:24 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 14:23 [PATCH 1/5] ARM: imx: Remove references to platform_bus in mxc code Pawel Moll
2014-07-25 14:23 ` [PATCH 2/5] char: tile-srom: Remove reference to platform_bus Pawel Moll
2014-07-31 20:24 ` Chris Metcalf [this message]
2014-07-31 21:32 ` Greg Kroah-Hartman
2014-08-01 17:21 ` Pawel Moll
2014-08-05 20:08 ` Chris Metcalf
2014-08-05 23:06 ` Greg Kroah-Hartman
2014-08-08 16:34 ` Pawel Moll
2014-08-08 16:39 ` Pawel Moll
2014-08-11 2:38 ` Chris Metcalf
2014-08-29 18:43 ` Chris Metcalf
2014-09-01 12:27 ` Pawel Moll
2014-09-01 13:53 ` Chris Metcalf
2014-07-25 14:23 ` [PATCH 3/5] mmc: sdhci-pltfm: Do not use parent as the host's device Pawel Moll
2014-08-08 16:36 ` Pawel Moll
2014-08-11 9:07 ` Ulf Hansson
2014-08-11 9:15 ` Pawel Moll
2014-08-11 9:32 ` Ulf Hansson
2014-08-12 8:58 ` Ulf Hansson
2014-08-12 10:37 ` [PATCH 3/5 v2] " Pawel Moll
2014-08-12 11:51 ` Ulf Hansson
2014-08-11 10:02 ` [PATCH 3/5] " Russell King - ARM Linux
2014-07-25 14:23 ` [PATCH 4/5] [SCSI] Do not use platform_bus as a parent Pawel Moll
2014-07-25 14:46 ` James Bottomley
2014-07-25 15:40 ` Pawel Moll
2014-07-26 20:11 ` Greg Kroah-Hartman
2014-07-27 3:52 ` James Bottomley
2014-07-27 15:07 ` Greg Kroah-Hartman
2014-08-01 17:25 ` Pawel Moll
2014-07-25 14:23 ` [PATCH 5/5] platform: Make platform_bus device a platform device Pawel Moll
2014-07-26 20:12 ` Greg Kroah-Hartman
2014-08-01 17:21 ` Pawel Moll
2014-07-26 20:13 ` Greg Kroah-Hartman
2014-08-01 17:21 ` Pawel Moll
2014-07-28 1:45 ` [PATCH 1/5] ARM: imx: Remove references to platform_bus in mxc code Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DAA605.2030500@tilera.com \
--to=cmetcalf@tilera.com \
--cc=Catalin.Marinas@arm.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=olof@lixom.net \
--cc=paul@pwsan.com \
--cc=pawel.moll@arm.com \
--cc=pdeschrijver@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox