From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753043AbaGaVcv (ORCPT ); Thu, 31 Jul 2014 17:32:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32898 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752145AbaGaVcu (ORCPT ); Thu, 31 Jul 2014 17:32:50 -0400 Message-ID: <53DAB5F3.9040609@redhat.com> Date: Thu, 31 Jul 2014 23:32:35 +0200 From: Hans de Goede User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Jeroen Hofstee , "Yann E. MORIN" , u-boot@lists.denx.de CC: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org Subject: Re: [U-Boot] [PATCH] kconfig: Fix compiler warning in menu.c References: <1406816503-31963-1-git-send-email-hdegoede@redhat.com> <53DAA2A0.3050205@myspectrum.nl> In-Reply-To: <53DAA2A0.3050205@myspectrum.nl> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 07/31/2014 10:10 PM, Jeroen Hofstee wrote: > Hello Hans, > > On 31-07-14 16:21, Hans de Goede wrote: >> This fixes the following compiler warning: >> >> In file included from scripts/kconfig/zconf.tab.c:2537:0: >> scripts/kconfig/menu.c: In function ‘get_symbol_str’: >> scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in this function [-Wmaybe-uninitialized] >> jump->offset = strlen(r->s); >> ^ >> In file included from scripts/kconfig/zconf.tab.c:2537:0: >> scripts/kconfig/menu.c:551:19: note: ‘jump’ was declared here >> struct jump_key *jump; >> >> Signed-off-by: Hans de Goede >> --- >> scripts/kconfig/menu.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c >> index a26cc5d..584e0fc 100644 >> --- a/scripts/kconfig/menu.c >> +++ b/scripts/kconfig/menu.c >> @@ -548,7 +548,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop, >> { >> int i, j; >> struct menu *submenu[8], *menu, *location = NULL; >> - struct jump_key *jump; >> + struct jump_key *jump = NULL; >> str_printf(r, _("Prompt: %s\n"), _(prop->text)); >> menu = prop->menu->parent; > > just curious, which compiler is this? Since it is a false positive. > (and it could know) [hans@shalem u-boot]$ rpm -q gcc gcc-4.9.1-2.fc21.1.x86_64 Regards, Hans