public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Prarit Bhargava <prarit@redhat.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Aaron Lu <aaron.lu@intel.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [BUG cpufreq] Invalid argument on writing to scaling_governor
Date: Fri, 01 Aug 2014 06:46:51 -0400	[thread overview]
Message-ID: <53DB701B.9070900@redhat.com> (raw)
In-Reply-To: <20140801104314.GA741@localhost>



On 08/01/2014 06:43 AM, Fengguang Wu wrote:
> Hi Prarit,
> 
> I noticed that commit dbcbfe6aa0d61ae5e13cab43b30802482007c199 ("cpufreq: hold
> policy->rwsem for duration of changing governors") will cause this problem:
> 
> root@nhm4 ~# echo performance > /sys/devices/system/cpu/cpu3/cpufreq/scaling_governor
> -bash: echo: write error: Invalid argument
> 
> root@nhm4 ~# cat /sys/devices/system/cpu/cpu3/cpufreq/scaling_available_governors
> conservative userspace powersave ondemand performance
> 

Rafael, this patch needs to be rejected based on my previous comments, most
notably Saravana was able to reproduce the original problem.  I'm going to wait
for his reproducer and see what I can do.

Thanks,

P.

> Thanks,
> Fengguang
> 

  reply	other threads:[~2014-08-01 10:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01 10:43 [BUG cpufreq] Invalid argument on writing to scaling_governor Fengguang Wu
2014-08-01 10:46 ` Prarit Bhargava [this message]
2014-08-01 12:47   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53DB701B.9070900@redhat.com \
    --to=prarit@redhat.com \
    --cc=aaron.lu@intel.com \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox