From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932296AbaHANey (ORCPT ); Fri, 1 Aug 2014 09:34:54 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:52889 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756425AbaHANew (ORCPT ); Fri, 1 Aug 2014 09:34:52 -0400 Message-ID: <53DB9751.6030508@ti.com> Date: Fri, 1 Aug 2014 16:34:09 +0300 From: Peter Ujfalusi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Sergei Shtylyov , , CC: , , , , , , Subject: Re: [PATCH 5/6] ARM: DTS: da850-evm: Add node for tlv320aic3106 codec References: <1406801934-23334-1-git-send-email-peter.ujfalusi@ti.com> <1406801934-23334-6-git-send-email-peter.ujfalusi@ti.com> <53DA519A.4090905@cogentembedded.com> <53DB240F.2030908@ti.com> <53DB8CEA.9010902@cogentembedded.com> <53DB8FE1.5010207@ti.com> <53DB9292.7080008@cogentembedded.com> In-Reply-To: <53DB9292.7080008@cogentembedded.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 08/01/2014 04:13 PM, Sergei Shtylyov wrote: > Hello. > > On 08/01/2014 05:02 PM, Peter Ujfalusi wrote: > >>> I do. We should follow the standard consistently. Why not call the node >>> "sound-codec"? > >> Well, there is _zero_ cases when the audio codec node is named as >> "sound-codec" in linux-next but we have wmXXXX, tlvXXXX, twlXXXX, maxXXXX etc. > > Which only means people don't read the standard (which is referred to on > http://www.devicetree.org/Device_Tree_Usage, that says the same). > >> Yeah, there are few DTS files which have codec as node name. >> So, no, I'm not going to change the node name from tlv320aic3106. > > So you prefer following the bad examples to following the standard? those bad examples are in the tree and they did went through the review process (arch, DT and probably alsa). But it is interesting that we do not have a single correct node name for audio codecs (probably for other types also). > Well, "the Moor has done his duty, the Moor can go"... Let's ask the DT maintainers what should be the correct approach and someone should go through all the existing DT files and clean them up? People usually start reading the code for examples before the standard... -- Péter