From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754306AbaHBKEA (ORCPT ); Sat, 2 Aug 2014 06:04:00 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:57074 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751533AbaHBKD6 (ORCPT ); Sat, 2 Aug 2014 06:03:58 -0400 Message-ID: <53DCB77C.5090604@gmail.com> Date: Sat, 02 Aug 2014 18:03:40 +0800 From: Lennox Wu User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Chen Gang , Liqin Chen CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] arch/score/kernel: Add 'score_ksyms.c' to export special symbols References: <53BC8AAD.4070408@gmail.com> In-Reply-To: <53BC8AAD.4070408@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Lennox Wu It was merged into Score's git tree, and it will show in the next PULL request. Best, Lennox Chen Gang 於 2014/7/9 上午 08:19 寫道: > Some symbols are not implemented in C, or not in "arch/score", but > score need export them, so add 'score_ksyms.c' to export them, just > like other architectures have done. > > The related error (with allmodconfig under score): > > MODPOST 1365 modules > ERROR: "__clear_user" [drivers/md/dm-mod.ko] undefined! > ERROR: "__copy_tofrom_user" [net/x25/x25.ko] undefined! > ERROR: "__strncpy_from_user" [fs/xfs/xfs.ko] undefined! > ERROR: "csum_partial" [net/unix/unix.ko] undefined! > > ERROR: "max_low_pfn" [net/wireless/lib80211_crypt_tkip.ko] undefined! > ERROR: "min_low_pfn" [net/wireless/lib80211_crypt_tkip.ko] undefined! > > > Signed-off-by: Chen Gang > --- > arch/score/kernel/Makefile | 2 +- > arch/score/kernel/score_ksyms.c | 41 +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 42 insertions(+), 1 deletion(-) > create mode 100644 arch/score/kernel/score_ksyms.c > > diff --git a/arch/score/kernel/Makefile b/arch/score/kernel/Makefile > index fb1802b..891133b 100644 > --- a/arch/score/kernel/Makefile > +++ b/arch/score/kernel/Makefile > @@ -6,6 +6,6 @@ extra-y := head.o vmlinux.lds > > obj-y += entry.o irq.o process.o ptrace.o \ > setup.o signal.o sys_score.o time.o traps.o \ > - sys_call_table.o > + sys_call_table.o score_ksyms.o > > obj-$(CONFIG_MODULES) += module.o > diff --git a/arch/score/kernel/score_ksyms.c b/arch/score/kernel/score_ksyms.c > new file mode 100644 > index 0000000..d093774 > --- /dev/null > +++ b/arch/score/kernel/score_ksyms.c > @@ -0,0 +1,41 @@ > +/* > + * arch/score/kernel/score_ksyms.c > + * > + * Score Processor version. > + * > + * No Copyright (C) > + * Chen Gang > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, see the file COPYING, or write > + * to the Free Software Foundation, Inc., > + * 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > + */ > + > +#include > +#include > +#include > + > +/* > + * Assembly functions that may be used (directly or indirectly) by modules > + */ > +EXPORT_SYMBOL(__clear_user); > +EXPORT_SYMBOL(__copy_tofrom_user); > +EXPORT_SYMBOL(__strncpy_from_user); > +EXPORT_SYMBOL(csum_partial); > + > +/* > + * Define but not export in generic mm sub-systems, but score need export > + */ > +EXPORT_SYMBOL(min_low_pfn); > +EXPORT_SYMBOL(max_low_pfn); >