From: Nikolay Aleksandrov <nikolay@redhat.com>
To: Thomas Graf <tgraf@suug.ch>, davem@davemloft.net, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kaber@trash.net,
paulmck@linux.vnet.ibm.com, josh@joshtriplett.org,
challa@noironetworks.com, walpole@cs.pdx.edu,
dev@openvswitch.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] lib: Resizable, Scalable, Concurrent Hash Table
Date: Sat, 02 Aug 2014 12:32:41 +0200 [thread overview]
Message-ID: <53DCBE49.5040507@redhat.com> (raw)
In-Reply-To: <f7740ef7d22a334a775348caee916f1ddb3c584d.1406971567.git.tgraf@suug.ch>
On 08/02/2014 11:47 AM, Thomas Graf wrote:
> Generic implementation of a resizable, scalable, concurrent hash table
> based on [0]. The implementation supports both, fixed size keys specified
> via an offset and length, or arbitrary keys via own hash and compare
> functions.
>
> Lookups are lockless and protected as RCU read side critical sections.
> Automatic growing/shrinking based on user configurable watermarks is
> available while allowing concurrent lookups to take place.
>
> Objects to be hashed must include a struct rhash_head. The reason for not
> using the existing struct hlist_head is that the expansion and shrinking
> will have two buckets point to a single entry which would lead in obscure
> reverse chaining behaviour.
>
> Code includes a boot selftest if CONFIG_TEST_RHASHTABLE is defined.
>
> [0] https://www.usenix.org/legacy/event/atc11/tech/final_files/Triplett.pdf
>
> Signed-off-by: Thomas Graf <tgraf@suug.ch>
> ---
> include/linux/rhashtable.h | 213 ++++++++++++
> lib/Kconfig.debug | 8 +
> lib/Makefile | 2 +-
> lib/rhashtable.c | 797 +++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 1019 insertions(+), 1 deletion(-)
> create mode 100644 include/linux/rhashtable.h
> create mode 100644 lib/rhashtable.c
>
Reviewed-by: Nikolay Aleksandrov <nikolay@redhat.com>
next prev parent reply other threads:[~2014-08-02 10:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-02 9:47 [PATCH net-next v5 0/3] Lockless netlink_lookup() with new concurrent hash table Thomas Graf
2014-08-02 9:47 ` [PATCH net-next 1/3] lib: Resizable, Scalable, Concurrent Hash Table Thomas Graf
2014-08-02 10:32 ` Nikolay Aleksandrov [this message]
2014-08-02 9:47 ` [PATCH net-next 2/3] netlink: Convert netlink_lookup() to use RCU protected hash table Thomas Graf
2014-08-02 10:44 ` Nikolay Aleksandrov
2014-08-05 2:10 ` Sasha Levin
2014-08-05 2:58 ` David Miller
2014-08-05 5:50 ` Eric Dumazet
2014-08-05 5:58 ` David Miller
2014-08-02 9:47 ` [PATCH net-next 3/3] nftables: Convert nft_hash to use generic rhashtable Thomas Graf
2014-08-02 10:56 ` Nikolay Aleksandrov
2014-08-03 2:53 ` [PATCH net-next v5 0/3] Lockless netlink_lookup() with new concurrent hash table David Miller
-- strict thread matches above, loose matches on Subject: below --
2014-08-01 11:58 [PATCH net-next v4 " Thomas Graf
2014-08-01 11:58 ` [PATCH net-next 1/3] lib: Resizable, Scalable, Concurrent Hash Table Thomas Graf
2014-08-01 8:51 [PATCH net-next v3 0/3] Lockless netlink_lookup() with new concurrent hash table Thomas Graf
2014-08-01 8:51 ` [PATCH net-next 1/3] lib: Resizable, Scalable, Concurrent Hash Table Thomas Graf
2014-08-01 10:01 ` Nikolay Aleksandrov
2014-08-01 10:33 ` Thomas Graf
2014-08-01 10:26 ` Patrick McHardy
2014-08-01 10:32 ` Thomas Graf
2014-07-31 22:56 [PATCH v2 0/3 net-next] Lockless netlink_lookup() with new concurrent hash table Thomas Graf
2014-07-31 22:56 ` [PATCH net-next 1/3] lib: Resizable, Scalable, Concurrent Hash Table Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DCBE49.5040507@redhat.com \
--to=nikolay@redhat.com \
--cc=challa@noironetworks.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=josh@joshtriplett.org \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tgraf@suug.ch \
--cc=walpole@cs.pdx.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).