From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754926AbaHBNJh (ORCPT ); Sat, 2 Aug 2014 09:09:37 -0400 Received: from mail-wg0-f47.google.com ([74.125.82.47]:48211 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752255AbaHBNJf (ORCPT ); Sat, 2 Aug 2014 09:09:35 -0400 Message-ID: <53DCE30A.7020201@gmail.com> Date: Sat, 02 Aug 2014 15:09:30 +0200 From: Tomasz Figa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , linux-samsung-soc@vger.kernel.org CC: Mark Rutland , devicetree@vger.kernel.org, Kukjin Kim , Vincent Palatin , Pawel Moll , Ian Campbell , open list , Tomasz Figa , Kumar Gala , Stephan van Schaik , Doug Anderson , Rob Herring , Ben Dooks , Russell King , Javier Martinez Canillas , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 04/10] ARM: dts: Clean up exynos5250-snow References: <1406940750-15880-1-git-send-email-afaerber@suse.de> <1406940750-15880-5-git-send-email-afaerber@suse.de> <53DCD7D7.2070208@gmail.com> <53DCDFF3.7030909@gmail.com> <53DCE2BA.7010803@suse.de> In-Reply-To: <53DCE2BA.7010803@suse.de> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02.08.2014 15:08, Andreas Färber wrote: > Am 02.08.2014 14:56, schrieb Tomasz Figa: >> On 02.08.2014 14:21, Tomasz Figa wrote: >>> On 02.08.2014 02:52, Andreas Färber wrote: >>>> Use the new style of referencing inherited nodes and use symbolic names. >>>> Reorder one pinctrl node in GPIO order. >>>> >>>> Goal is the alignment of all exynos5250 based device trees for comparison. >>>> >>>> Suggested-by: Doug Anderson >>>> Reviewed-by: Doug Anderson >>>> Signed-off-by: Andreas Färber >>>> --- >>>> v5 -> v6: >>>> * Split off label additions (Doug Anderson) >>>> * Fixed alphabetical order of sd3_* nodes (Doug Anderson) >>>> >>>> v4 -> v5: >>>> * Introduced labels to consistently use new referencing style (Tomasz Figa) >>>> * Use IRQ_TYPE_* constants >>>> * Use some more GPIO_ACTIVE_* >>>> >>>> v3 -> v4: Unchanged >>>> >>>> v3: New (Doug Anderson) >>>> >>>> arch/arm/boot/dts/exynos5250-snow.dts | 291 +++++++++++++++++----------------- >>>> 1 file changed, 145 insertions(+), 146 deletions(-) >>> >>> Reviewed-by: Tomasz Figa >> >> Just for convenience of other reviewers, here are actual changes done do >> the device tree after compiling into dtb and then back into dts: > > Erm, to not confuse reviewers, this must be over the whole series: Erm, right, I have forgot to state this, sorry. Similarly for other dtb diffs. Best regards, Tomasz