From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752950AbaHCQbA (ORCPT ); Sun, 3 Aug 2014 12:31:00 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:59295 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752878AbaHCQa7 (ORCPT ); Sun, 3 Aug 2014 12:30:59 -0400 Message-ID: <53DE650E.4060909@gmail.com> Date: Sun, 03 Aug 2014 18:36:30 +0200 From: Goffredo Baroncelli Reply-To: kreijack@inwind.it User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Jean Delvare , kreijack@inwind.it CC: Benjamin Herrenschmidt , linux-kernel@vger.kernel.org, bryan@whatroute.net Subject: Re: [PATCH 3/4] Add the "verbose" module option. References: <1406901650-20841-1-git-send-email-kreijack@inwind.it> <1406901650-20841-4-git-send-email-kreijack@inwind.it> <20140803161223.0b26e4bc@endymion.delvare> <53DE5179.3080402@gmail.com> <20140803175222.3433b646@endymion.delvare> In-Reply-To: <20140803175222.3433b646@endymion.delvare> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/03/2014 05:52 PM, Jean Delvare wrote: > On Sun, 03 Aug 2014 17:12:57 +0200, Goffredo Baroncelli wrote: >> On 08/03/2014 04:12 PM, Jean Delvare wrote: >>>> + (verbose > 0 && level >= 0)) { >>>> + print_temp("CPU-temp: ", temp ); >>>> + if (casetemp) >>>> + print_temp(", Case: ", casetemp ); >>>> + if (level >= 0) >>>> + printk(", Fan: %d (tuned %+d)\n", 11-level, >>>> + x.fan_level-level ); >>>> + else >>>> + printk(", Fan: %d (tuned +0)\n",x.fan_level); >>> >>> I think you can do without the "tuned +0" which doesn't add much value. >> >> Me too. But the old driver does the same, so I preferred to >> leave it as is. > > I looked at the code again and no, I can't see the old code doing that. > It has "tuned %+d" only in tune_fan() which is only called if > level >= 0. The other printk (when tune_fan isn't called) doesn't have > a "tuned" part. > This is taken from an old log of a v3.2 kernel (no changes here): [ 886.510879] CPU-temp: 55.4 C, Case: 33.1 C, Fan: 0 (tuned -11) [ 910.522869] CPU-temp: 56.0 C, Case: 33.5 C, Fan: 0 (tuned +0) [ 958.546880] CPU-temp: 57.0 C, Case: 34.1 C, Fan: 3 (tuned +3) in the code if level <0, then there is no update in the log. But if level >0 and level is equal to the previous one, this leads to have "tuned +0"... But I have to be honest: I have not fully understand how "level" is computed. The printk without "(tuned %+d)" is never called because LOG_TEMP was #define(d) equal to 0. -- gpg @keyserver.linux.it: Goffredo Baroncelli (kreijackATinwind.it> Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0EDA 9B37 8B82 E0B5