From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752511AbaHDL27 (ORCPT ); Mon, 4 Aug 2014 07:28:59 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57285 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752049AbaHDL25 (ORCPT ); Mon, 4 Aug 2014 07:28:57 -0400 Message-ID: <53DF6E77.1010804@suse.com> Date: Mon, 04 Aug 2014 13:28:55 +0200 From: Juergen Gross User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: James.Bottomley@HansenPartnership.com, hch@infradead.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4] Save command pool address of Scsi_Host References: <1407151460-26888-1-git-send-email-jgross@suse.com> In-Reply-To: <1407151460-26888-1-git-send-email-jgross@suse.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/04/2014 01:24 PM, jgross@suse.com wrote: > From: Juergen Gross > > If a scsi host driver specifies .cmd_len in it's scsi_host_template, a driver's > private command pool is needed. scsi_find_host_cmd_pool() will locate it, but > scsi_alloc_host_cmd_pool() isn't saving the pool address in the host template. > > This will result in an access error when the host is removed. > > Avoid the problem by saving the address of a new allocated command pool where > it is expected. Please ignore, should have used pool instead hostt->cm_pool for calling scsi_free_host_cmd_pool(). V5 follows... Juergen > > Signed-off-by: Juergen Gross > --- > drivers/scsi/scsi.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c > index 88d46fe..f654ac1 100644 > --- a/drivers/scsi/scsi.c > +++ b/drivers/scsi/scsi.c > @@ -380,6 +380,10 @@ scsi_alloc_host_cmd_pool(struct Scsi_Host *shost) > pool->slab_flags |= SLAB_CACHE_DMA; > pool->gfp_mask = __GFP_DMA; > } > + > + if (hostt->cmd_size) > + hostt->cmd_pool = pool; > + > return pool; > } > > @@ -424,8 +428,10 @@ out: > out_free_slab: > kmem_cache_destroy(pool->cmd_slab); > out_free_pool: > - if (hostt->cmd_size) > - scsi_free_host_cmd_pool(pool); > + if (hostt->cmd_size) { > + scsi_free_host_cmd_pool(hostt->cmd_pool); > + hostt->cmd_pool = NULL; > + } > goto out; > } > > @@ -447,8 +453,10 @@ static void scsi_put_host_cmd_pool(struct Scsi_Host *shost) > if (!--pool->users) { > kmem_cache_destroy(pool->cmd_slab); > kmem_cache_destroy(pool->sense_slab); > - if (hostt->cmd_size) > - scsi_free_host_cmd_pool(pool); > + if (hostt->cmd_size) { > + scsi_free_host_cmd_pool(hostt->cmd_pool); > + hostt->cmd_pool = NULL; > + } > } > mutex_unlock(&host_cmd_pool_mutex); > } >