linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Hounschell <markh@compro.net>
To: DaeSeok Youn <daeseok.youn@gmail.com>
Cc: Lidza Louina <lidza.louina@gmail.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	driverdev-devel@linuxdriverproject.org,
	devel <devel@driverdev.osuosl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH V2] staging: dgap: introduce dgap_cleanup_nodes()
Date: Mon, 04 Aug 2014 08:40:20 -0400	[thread overview]
Message-ID: <53DF7F34.5030201@compro.net> (raw)
In-Reply-To: <1598413764.80217.1406848485858.JavaMail.root@mx2.compro.net>

On 07/31/2014 07:14 PM, DaeSeok Youn wrote:
> Hi, Mark
>
> 2014-07-31 21:44 GMT+09:00 Mark Hounschell <markh@compro.net>:
>> On 07/31/2014 12:02 AM, Daeseok Youn wrote:
>>>
>>> When a configration file is parsed with dgap_parsefile(),
>>> makes nodes for saving configrations for board.
>>>
>>> Making a node will allocate node memory and strings for saving
>>> configrations with kstrdup().
>>>
>>> So these are freed when dgap is unloaded or failed to initialize.
>>>
>>> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
>>> ---
>>> V2: Do not need to free for NULLNODE.
>>>
>>> I have been too busy to solve this issue, sorry for late.
>>>
>>> Mark, Can you test this patch? I try to make simple module which is
>>> testing dgap_parsefile() and dgap_cleanup_nodes().
>>>
>>
>> I'll be happy to, but I can't do it until Monday. I'm not where the hardware
>> is until then.
> That's OK. :-)
>

After applying this patch I am still able to load and unload the driver 
at will, and it still works for me.

Regards
Mark


  parent reply	other threads:[~2014-08-04 12:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166070137.57941.1406779444750.JavaMail.root@mx2.compro.net>
2014-07-31 12:44 ` [PATCH V2] staging: dgap: introduce dgap_cleanup_nodes() Mark Hounschell
2014-07-31 23:14   ` DaeSeok Youn
     [not found]   ` <1598413764.80217.1406848485858.JavaMail.root@mx2.compro.net>
2014-08-04 12:40     ` Mark Hounschell [this message]
2014-08-04 23:33       ` DaeSeok Youn
2014-08-04 23:38         ` Greg KH
2014-08-05  0:48           ` DaeSeok Youn
2014-07-31  4:02 Daeseok Youn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53DF7F34.5030201@compro.net \
    --to=markh@compro.net \
    --cc=daeseok.youn@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lidza.louina@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).