Re: [PATCH 2/4] perf tools: allow user to specify hardware breakpoint bp_len

Suravee Suthikulanit
2014-08-04T19:28:30Z

Frederic,

3.17 windows is now open. Do you think you could get this one in?

Thanks

Suravee

On 6/6/2014 11:30 AM, Suravee Suthikulanit wrote:
> This message has been archived. View the original item
> <http://ausev2.amd.com/EnterpriseVault/ViewMessage.asp?VaultId=1C7248B8A7CDE234D884C352F0CB2021B1110000amdvault.amd.com&SavesetId=201407115122720~201406061630160000~Z~F134EBF86540766B73DA6ADB45060FE1>
> On 6/3/2014 6:55 AM, Jiri Olsa wrote:
> > On Tue, Jun 03, 2014 at 10:36:22AM +0900, Namhyung Kim wrote:
> >> Hi Jiri,
> >>
> >> On Fri, 30 May 2014 15:39:06 +0200, Jiri Olsa wrote:
> >>> On Thu, May 29, 2014 at 05:26:51PM +0200, Frederic Weisbecker wrote:
> >>>> From: Jacob Shin <jacob.w.shin@gmail.com>
> >>>>
> >>>> Currently bp_len is given a default value of 4. Allow user to
> override it:
> >>>>
> >>>> $ perf stat -e mem:0x1000/8
> >>>> ^
> >>>> bp_len
> >>>>
> >>>> If no value is given, it will default to 4 as it did before.
> >>>
> >>> Namhyung,
> >>> both perf tols patches from this patchset mess up with hists
> >>> tests.. I havent found any connection yet.. any idea? ;-)
> >>
> >> So you already found the problem in the hpp->elide change and that's the
> >> reason of the failure, right? :)
> >
> > I haven't got a chance to test it yet.. but it looks like
> > thats the case.. I'll retest soon ;-)
> >
> > jirka
> >
> Anything I can do to help here?
>
> Thanks,
>
> Suravee
>