Re: [PATCH 2/4] perf tools: allow user to specify hardware breakpoint bp_len

Jiri Olsa
2014-06-03T11:55:39Z

On Tue, Jun 03, 2014 at 10:36:22AM +0900, Namhyung Kim wrote:
> Hi Jiri,
>
> On Fri, 30 May 2014 15:39:06 +0200, Jiri Olsa wrote:
> > On Thu, May 29, 2014 at 05:26:51PM +0200, Frederic Weisbecker wrote:
> >> From: Jacob Shin <jacob.w.shin@gmail.com>
> >>
> >> Currently bp_len is given a default value of 4. Allow user to override it:
> >>
> >> $ perf stat -e mem:0x1000/8
> >> ^
> >> bp_len
> >>
> >> If no value is given, it will default to 4 as it did before.
> >
> > Namhyung,
> > both perf tols patches from this patchset mess up with hists
> > tests.. I havent found any connection yet.. any idea? ;-)
>
> So you already found the problem in the hpp->elide change and that's the
> reason of the failure, right? :)

I haven't got a chance to test it yet.. but it looks like
thats the case.. I'll retest soon ;-)

jirka