From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Sasha Levin <sasha.levin@oracle.com>,
gleb@kernel.org, pbonzini@redhat.com
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: MMU: Use hashtable for MMU page hash
Date: Tue, 05 Aug 2014 12:00:02 +0800 [thread overview]
Message-ID: <53E056C2.9070101@linux.vnet.ibm.com> (raw)
In-Reply-To: <1407185689-27727-1-git-send-email-sasha.levin@oracle.com>
On 08/05/2014 04:54 AM, Sasha Levin wrote:
> Use the kernel hashtable interface instead of the hlist interface.
> This allows us to eliminate some unneeded code and make the code
> simpler.
The side effect is that the hash function is changed, the current
way is:
gfn & ((1 << KVM_MMU_HASH_SHIFT) - 1);
Guest memory is always continuous and big region, i guess it's better
than the one you introduced.
Anyway, benchmark is needed and always welcome. :)
prev parent reply other threads:[~2014-08-05 4:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 20:54 [PATCH] KVM: MMU: Use hashtable for MMU page hash Sasha Levin
2014-08-05 4:00 ` Xiao Guangrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E056C2.9070101@linux.vnet.ibm.com \
--to=xiaoguangrong@linux.vnet.ibm.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).