From: Rik van Riel <riel@redhat.com>
To: Aaron Lu <aaron.lu@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
lkp@01.org, jhladky@redhat.com
Subject: Re: [LKP] [sched/numa] a43455a1d57: +94.1% proc-vmstat.numa_hint_faults_local
Date: Tue, 05 Aug 2014 17:43:13 -0400 [thread overview]
Message-ID: <53E14FF1.50904@redhat.com> (raw)
In-Reply-To: <20140731050454.GA9386@aaronlu.sh.intel.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 07/31/2014 01:04 AM, Aaron Lu wrote:
>>>> +++ b/kernel/sched/fair.c @@ -924,10 +924,12 @@ static inline
>>>> unsigned long group_faults_cpu(struct numa_group *group, int
>>>> nid)
>>>>
>>>> /* * These return the fraction of accesses done by a
>>>> particular task, or - * task group, on a particular numa
>>>> node. The group weight is given a - * larger multiplier, in
>>>> order to group tasks together that are almost - * evenly
>>>> spread out between numa nodes. + * task group, on a
>>>> particular numa node. The NUMA move threshold + * prevents
>>>> task moves with marginal improvement, and is set to 5%. */
>>>> +#define NUMA_SCALE 1024 +#define NUMA_MOVE_THRESH (5 *
>>>> NUMA_SCALE / 100)
>>
>> It would be good to see if changing NUMA_MOVE_THRESH to
>> (NUMA_SCALE / 8) does the trick.
>
> With your 2nd patch and the above change, the result is:
Peter,
the threshold does not seem to make a difference for the
performance tests on my system, I guess you can drop this
patch :)
- --
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJT4U/xAAoJEM553pKExN6DY4oH/ihJDmcCSZ0sKqGbyzJqLrFY
KWCEXhfiN6hQJBrmeOvrbzlHsMH0LzYfgTVnc1nteAcnUXiBeqkgxwf+S1dmvoFr
DZSxC+9tQ68ho0YcLd7rpEMfsnwOQAB9BgX8GxxwMb8q5zZ9Bz3r9NKVF0P2D3cj
eeJ8Z3EGaKOteVhwAPVPeuTf7xwhqoqp4ujLgTL7BcaifqvGhi3+uo9/KcavE15d
eale3MuhbCIsAQeyB4SwgGwilE/oZTPTos4BNdUrIyxO4nDajbeLb1qsLSHYcirH
CA7++bTE9V6TvO1tBLVpeYdSAGcDKKUBHM6N+0UDwkR/Tp4oRyQ115Peo2H34ak=
=kFxZ
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-08-05 21:43 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53d70ee6.JsUEmW5dWsv8dev+%fengguang.wu@intel.com>
2014-07-29 5:24 ` [LKP] [sched/numa] a43455a1d57: +94.1% proc-vmstat.numa_hint_faults_local Aaron Lu
2014-07-29 6:39 ` Rik van Riel
2014-07-29 8:17 ` Peter Zijlstra
2014-07-29 20:04 ` Rik van Riel
2014-07-30 2:14 ` Aaron Lu
2014-07-30 14:25 ` Rik van Riel
2014-07-31 5:04 ` Aaron Lu
2014-07-31 6:22 ` Rik van Riel
2014-07-31 6:53 ` Aaron Lu
2014-07-31 6:42 ` Rik van Riel
2014-08-05 21:43 ` Rik van Riel [this message]
2014-07-31 8:33 ` Peter Zijlstra
2014-07-31 8:56 ` Aaron Lu
2014-07-31 10:42 ` Peter Zijlstra
2014-07-31 15:57 ` Peter Zijlstra
2014-07-31 16:16 ` Jirka Hladky
2014-07-31 16:27 ` Peter Zijlstra
2014-07-31 16:39 ` Jirka Hladky
2014-07-31 17:37 ` Peter Zijlstra
2014-08-01 15:02 ` Peter Zijlstra
2014-08-01 20:46 ` Davidlohr Bueso
2014-08-01 20:48 ` Davidlohr Bueso
2014-08-01 21:30 ` Jirka Hladky
2014-08-02 4:17 ` Rik van Riel
2014-08-02 5:28 ` Jirka Hladky
2014-08-02 4:26 ` Peter Zijlstra
2014-08-01 0:18 ` Davidlohr Bueso
2014-08-01 2:03 ` Aaron Lu
2014-08-01 4:03 ` Davidlohr Bueso
2014-08-01 7:29 ` Peter Zijlstra
2014-08-01 7:29 ` Peter Zijlstra
2014-07-31 23:58 ` Yuyang Du
2014-08-01 8:14 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E14FF1.50904@redhat.com \
--to=riel@redhat.com \
--cc=aaron.lu@intel.com \
--cc=jhladky@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox