From: Michal Marek <mmarek@suse.cz>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Himangi Saraogi <himangi774@gmail.com>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Coccinelle: Script to replace if and BUG with BUG_ON
Date: Wed, 06 Aug 2014 11:34:42 +0200 [thread overview]
Message-ID: <53E1F6B2.90201@suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.02.1408052015440.2047@localhost6.localdomain6>
On 2014-08-05 20:16, Julia Lawall wrote:
>
>
> On Tue, 5 Aug 2014, Michal Marek wrote:
>
>> On 2014-07-20 23:36, Himangi Saraogi wrote:
>>> This script detects cases where BUG() follows an if condition on an
>>> expression and replaces the if condition and BUG() with a BUG_ON having
>>> the conditional expression of the if statement as argument.
>>>
>>> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
>>> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
>>
>> Is this a result of some internal review, or where does Julia's Acked-by
>> come from? I'm just wondering, because I haven't seen any previous
>> version of this patch.
>
> She sent it to me first. It's OK with me.
OK, thanks for confirming. I'm going to merge this and the previous
patches by Himangi.
Michal
prev parent reply other threads:[~2014-08-06 9:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-20 21:36 [PATCH] Coccinelle: Script to replace if and BUG with BUG_ON Himangi Saraogi
2014-08-05 14:27 ` Michal Marek
2014-08-05 18:16 ` Julia Lawall
2014-08-06 9:34 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E1F6B2.90201@suse.cz \
--to=mmarek@suse.cz \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=himangi774@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox