[PATCH] kbuild: devtest - new make target for build all and run tests

[PATCH] kbuild: devtest - new make target for build all and run tests

[Shuah Khan]

Add a new devtest make target to enable developer testing. This
new target does full build (make all) and then runs selftests.

Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
---
 Makefile | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/Makefile b/Makefile
index f3c543d..1ef3128 100644
--- a/Makefile
+++ b/Makefile
@@ -1034,6 +1034,14 @@ headers_check: headers_install
 	$(Q)$(MAKE) $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) HDRCHECK=1
 
 # ---------------------------------------------------------------------------
+# Kernel devtest
+
+PHONY += devtest
+devtest:
+	make all
+	make -C tools/testing/selftests run_tests
+
+# ---------------------------------------------------------------------------
 # Modules
 
 ifdef CONFIG_MODULES
@@ -1236,6 +1244,9 @@ help:
 	@echo  '  headerdep       - Detect inclusion cycles in headers'
 	@$(MAKE) -f $(srctree)/scripts/Makefile.help checker-help
 	@echo  ''
+	@echo  'Developer test'
+	@echo  '  devtest      - Build all and run tests'
+	@echo  ''
 	@echo  'Kernel packaging:'
 	@$(MAKE) $(build)=$(package-dir) help
 	@echo  ''
-- 
1.9.1

Re: [PATCH] kbuild: devtest - new make target for build all and run tests

[Greg KH]

On Fri, Jul 18, 2014 at 02:44:34PM -0600, Shuah Khan wrote:
> Add a new devtest make target to enable developer testing. This
> new target does full build (make all) and then runs selftests.
> 
> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>

Nice to see this.

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Re: [PATCH] kbuild: devtest - new make target for build all and run tests

[Sam Ravnborg]

On Fri, Jul 18, 2014 at 02:44:34PM -0600, Shuah Khan wrote:
> Add a new devtest make target to enable developer testing. This
> new target does full build (make all) and then runs selftests.
> 
> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> ---
>  Makefile | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index f3c543d..1ef3128 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1034,6 +1034,14 @@ headers_check: headers_install
>  	$(Q)$(MAKE) $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) HDRCHECK=1
>  
>  # ---------------------------------------------------------------------------
> +# Kernel devtest
> +
> +PHONY += devtest
> +devtest:
> +	make all
> +	make -C tools/testing/selftests run_tests

The name "devtest" does not give any hints that we are actually
running the suite of selftest programs.

Is it so because the plan is to extend devtest to cover more than just selftest?
If not please fix it so it is logical for the user what happens - in other
words name is selftest or something like that.

	Sam

Re: [PATCH] kbuild: devtest - new make target for build all and run tests

[Shuah Khan]

On 07/18/2014 05:29 PM, Sam Ravnborg wrote:
> On Fri, Jul 18, 2014 at 02:44:34PM -0600, Shuah Khan wrote:
>> Add a new devtest make target to enable developer testing. This
>> new target does full build (make all) and then runs selftests.
>>
>> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
>> ---
>>   Makefile | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/Makefile b/Makefile
>> index f3c543d..1ef3128 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1034,6 +1034,14 @@ headers_check: headers_install
>>   	$(Q)$(MAKE) $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) HDRCHECK=1
>>
>>   # ---------------------------------------------------------------------------
>> +# Kernel devtest
>> +
>> +PHONY += devtest
>> +devtest:
>> +	make all
>> +	make -C tools/testing/selftests run_tests
>
> The name "devtest" does not give any hints that we are actually
> running the suite of selftest programs.
>
> Is it so because the plan is to extend devtest to cover more than just selftest?
> If not please fix it so it is logical for the user what happens - in other
> words name is selftest or something like that.
>

Yes the intent is to cover more than just selftests in the future.
That is why the target is called devtest.

-- Shuah


-- 
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@samsung.com | (970) 672-0658

Re: [PATCH] kbuild: devtest - new make target for build all and run tests

[Shuah Khan]

On 07/18/2014 06:13 PM, Shuah Khan wrote:
> On 07/18/2014 05:29 PM, Sam Ravnborg wrote:
>> On Fri, Jul 18, 2014 at 02:44:34PM -0600, Shuah Khan wrote:
>>> Add a new devtest make target to enable developer testing. This
>>> new target does full build (make all) and then runs selftests.
>>>
>>> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
>>> ---
>>>   Makefile | 11 +++++++++++
>>>   1 file changed, 11 insertions(+)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index f3c543d..1ef3128 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -1034,6 +1034,14 @@ headers_check: headers_install
>>>       $(Q)$(MAKE) $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm
>>> $(hdr-dst) HDRCHECK=1
>>>

Hi Michal,

Are you planning to include this patch in your 3.17 kbuild pull?
Keeping my fingers crossed. :)

-- Shuah


-- 
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@samsung.com | (970) 672-0658

Re: [PATCH] kbuild: devtest - new make target for build all and run tests

[Michal Marek]

On 2014-07-18 22:44, Shuah Khan wrote:
> Add a new devtest make target to enable developer testing. This
> new target does full build (make all) and then runs selftests.

I agree with Sam that the name is rather ambiguous, but I can't suggest
a better alternative right now.


> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> ---
>  Makefile | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index f3c543d..1ef3128 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1034,6 +1034,14 @@ headers_check: headers_install
>  	$(Q)$(MAKE) $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) HDRCHECK=1
>  
>  # ---------------------------------------------------------------------------
> +# Kernel devtest
> +
> +PHONY += devtest
> +devtest:
> +	make all

devtest: all


> +	make -C tools/testing/selftests run_tests

Please use $(Q)$(MAKE), to keep the build silent by default and to
consistently use the same make program with the same options throughout
the build.

Thanks,
Michal

Re: [PATCH] kbuild: devtest - new make target for build all and run tests

[Shuah Khan]

On 08/06/2014 07:51 AM, Michal Marek wrote:
> On 2014-07-18 22:44, Shuah Khan wrote:
>> Add a new devtest make target to enable developer testing. This
>> new target does full build (make all) and then runs selftests.
>
> I agree with Sam that the name is rather ambiguous, but I can't suggest
> a better alternative right now.

Does kselftest or kern_selftest sound better?

>
>
>> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
>> ---
>>   Makefile | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/Makefile b/Makefile
>> index f3c543d..1ef3128 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1034,6 +1034,14 @@ headers_check: headers_install
>>   	$(Q)$(MAKE) $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) HDRCHECK=1
>>
>>   # ---------------------------------------------------------------------------
>> +# Kernel devtest
>> +
>> +PHONY += devtest
>> +devtest:
>> +	make all
>
> devtest: all
>
>
>> +	make -C tools/testing/selftests run_tests
>
> Please use $(Q)$(MAKE), to keep the build silent by default and to
> consistently use the same make program with the same options throughout
> the build.
>

Working on the change - send v2 patch.

-- Shuah


-- 
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@samsung.com | (970) 672-0658

Re: [PATCH] kbuild: devtest - new make target for build all and run tests

[Michal Marek]

On 2014-08-06 16:04, Shuah Khan wrote:
> On 08/06/2014 07:51 AM, Michal Marek wrote:
>> On 2014-07-18 22:44, Shuah Khan wrote:
>>> Add a new devtest make target to enable developer testing. This
>>> new target does full build (make all) and then runs selftests.
>>
>> I agree with Sam that the name is rather ambiguous, but I can't suggest
>> a better alternative right now.
> 
> Does kselftest or kern_selftest sound better?

It does sound better to me than dev(ice)test, but I'm not a native
English speaker. Greg?


>>> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
>>> ---
>>>   Makefile | 11 +++++++++++
>>>   1 file changed, 11 insertions(+)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index f3c543d..1ef3128 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -1034,6 +1034,14 @@ headers_check: headers_install
>>>   	$(Q)$(MAKE) $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) HDRCHECK=1
>>>
>>>   # ---------------------------------------------------------------------------
>>> +# Kernel devtest
>>> +
>>> +PHONY += devtest
>>> +devtest:
>>> +	make all
>>
>> devtest: all
>>
>>
>>> +	make -C tools/testing/selftests run_tests
>>
>> Please use $(Q)$(MAKE), to keep the build silent by default and to
>> consistently use the same make program with the same options throughout
>> the build.
>>
> 
> Working on the change - send v2 patch.

Great!

Michal

Re: [PATCH] kbuild: devtest - new make target for build all and run tests

[Greg KH]

On Wed, Aug 06, 2014 at 04:06:33PM +0200, Michal Marek wrote:
> On 2014-08-06 16:04, Shuah Khan wrote:
> > On 08/06/2014 07:51 AM, Michal Marek wrote:
> >> On 2014-07-18 22:44, Shuah Khan wrote:
> >>> Add a new devtest make target to enable developer testing. This
> >>> new target does full build (make all) and then runs selftests.
> >>
> >> I agree with Sam that the name is rather ambiguous, but I can't suggest
> >> a better alternative right now.
> > 
> > Does kselftest or kern_selftest sound better?
> 
> It does sound better to me than dev(ice)test, but I'm not a native
> English speaker. Greg?

Either is fine with me, but I don't think we have '_' as any make target
today, so perhaps "kselftest" is best?

thanks,

greg k-h

Re: [PATCH] kbuild: devtest - new make target for build all and run tests

[Shuah Khan]

On 08/06/2014 08:31 AM, Greg KH wrote:
> On Wed, Aug 06, 2014 at 04:06:33PM +0200, Michal Marek wrote:
>> On 2014-08-06 16:04, Shuah Khan wrote:
>>> On 08/06/2014 07:51 AM, Michal Marek wrote:
>>>> On 2014-07-18 22:44, Shuah Khan wrote:
>>>>> Add a new devtest make target to enable developer testing. This
>>>>> new target does full build (make all) and then runs selftests.
>>>>
>>>> I agree with Sam that the name is rather ambiguous, but I can't suggest
>>>> a better alternative right now.
>>>
>>> Does kselftest or kern_selftest sound better?
>>
>> It does sound better to me than dev(ice)test, but I'm not a native
>> English speaker. Greg?
>
> Either is fine with me, but I don't think we have '_' as any make target
> today, so perhaps "kselftest" is best?
>
> thanks,
>
> greg k-h
>

Patch v2 is on its way. kselftest is the new target. It does sound lot
better than devtest :)

-- Shuah

-- 
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@samsung.com | (970) 672-0658