public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: shuah.kh@samsung.com, gregkh@linuxfoundation.org
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: devtest - new make target for build all and run tests
Date: Wed, 06 Aug 2014 16:06:33 +0200	[thread overview]
Message-ID: <53E23669.5050309@suse.cz> (raw)
In-Reply-To: <53E235DE.70604@samsung.com>

On 2014-08-06 16:04, Shuah Khan wrote:
> On 08/06/2014 07:51 AM, Michal Marek wrote:
>> On 2014-07-18 22:44, Shuah Khan wrote:
>>> Add a new devtest make target to enable developer testing. This
>>> new target does full build (make all) and then runs selftests.
>>
>> I agree with Sam that the name is rather ambiguous, but I can't suggest
>> a better alternative right now.
> 
> Does kselftest or kern_selftest sound better?

It does sound better to me than dev(ice)test, but I'm not a native
English speaker. Greg?


>>> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
>>> ---
>>>   Makefile | 11 +++++++++++
>>>   1 file changed, 11 insertions(+)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index f3c543d..1ef3128 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -1034,6 +1034,14 @@ headers_check: headers_install
>>>   	$(Q)$(MAKE) $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) HDRCHECK=1
>>>
>>>   # ---------------------------------------------------------------------------
>>> +# Kernel devtest
>>> +
>>> +PHONY += devtest
>>> +devtest:
>>> +	make all
>>
>> devtest: all
>>
>>
>>> +	make -C tools/testing/selftests run_tests
>>
>> Please use $(Q)$(MAKE), to keep the build silent by default and to
>> consistently use the same make program with the same options throughout
>> the build.
>>
> 
> Working on the change - send v2 patch.

Great!

Michal


  reply	other threads:[~2014-08-06 14:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-18 20:44 [PATCH] kbuild: devtest - new make target for build all and run tests Shuah Khan
2014-07-18 21:06 ` Greg KH
2014-07-18 23:29 ` Sam Ravnborg
2014-07-19  0:13   ` Shuah Khan
2014-08-06 13:41     ` Shuah Khan
2014-08-06 13:51 ` Michal Marek
2014-08-06 14:04   ` Shuah Khan
2014-08-06 14:06     ` Michal Marek [this message]
2014-08-06 14:31       ` Greg KH
2014-08-07 13:59         ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53E23669.5050309@suse.cz \
    --to=mmarek@suse.cz \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shuah.kh@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox