From: Waiman Long <waiman.long@hp.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@canonical.com>,
Rik van Riel <riel@redhat.com>,
linux-kernel@vger.kernel.org,
Scott J Norton <scott.norton@hp.com>,
Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH 2/2 v6] locking/selftest: Support queued rwlock
Date: Wed, 06 Aug 2014 13:24:36 -0400 [thread overview]
Message-ID: <53E264D4.5090800@hp.com> (raw)
In-Reply-To: <20140805132837.GA19379@twins.programming.kicks-ass.net>
On 08/05/2014 09:28 AM, Peter Zijlstra wrote:
> On Tue, Jul 29, 2014 at 02:53:19PM -0400, Waiman Long wrote:
>> The queued rwlock does not support the use of recursive read-lock in
>> the process context. With changes in the lockdep code to check and
>> disallow recursive read-lock, it is also necessary for the locking
>> selftest to be updated to change the process context recursive read
>> locking results from SUCCESS to FAILURE for rwlock.
>>
> Maybe I wasn't clear; but I meant you should extend the lock tests to
> cover the full qrwlock semantics.
>
> That means we also need tests like:
>
> RL(X1);
> IRQ_ENTER();
> RL(X2);
> IRQ_EXIT();
>
> To fully validate that in_interrupt exception to fairness etc..
Sorry for misinterpretation. I have just sent out an updated patch with
additional self tests to verify that recursive read-lock is allowed
under interrupt context.
-Longman
prev parent reply other threads:[~2014-08-06 17:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 18:53 [PATCH 0/2 v6] lockdep: add support for queued rwlock Waiman Long
2014-07-29 18:53 ` [PATCH 1/2 v6] locking/lockdep: Restrict the use of recursive read_lock() with qrwlock Waiman Long
2014-07-29 18:53 ` [PATCH 2/2 v6] locking/selftest: Support queued rwlock Waiman Long
2014-08-05 13:28 ` Peter Zijlstra
2014-08-05 14:07 ` Shuah Khan
2014-08-05 14:41 ` Peter Zijlstra
2014-08-05 14:44 ` Maarten Lankhorst
2014-08-05 14:54 ` Peter Zijlstra
2014-08-05 15:05 ` Shuah Khan
2014-08-05 15:25 ` Peter Zijlstra
2014-08-05 15:45 ` Shuah Khan
2014-08-06 17:24 ` Waiman Long [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E264D4.5090800@hp.com \
--to=waiman.long@hp.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@canonical.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=scott.norton@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox