From: Hyogi Gim <hyogi.gim@lge.com>
To: Andrew Morton <akpm@linux-foundation.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH] driver/rtc/class.c: check the error after rtc_read_time()
Date: Thu, 07 Aug 2014 10:58:14 +0900 [thread overview]
Message-ID: <53E2DD36.8000306@lge.com> (raw)
In-Reply-To: <20140723171922.216f55bb.akpm@linux-foundation.org>
On 07/24/2014 09:19 AM, Andrew Morton wrote:
>
> So what should rtc do in this case? At present it pretends the read
> succeeded. Either way, this doesn't seem to be the place to be making
> such policy decisions..
>
>
>
I agree. But, in this case, RTC device driver can not do anything. And if
rtc_suspend() returns a minus value, then suspend will be aborted. So,
in the worst case, suspend will be failed continually. I think this is not
good.
Most RTC device drivers don't verify the read time value. Even some drivers
just return '0' value(omap, tegra, ...). So, I think the higher level
framework like /drivers/rtc/interface.c should check and handle the rtc
read time.
prev parent reply other threads:[~2014-08-07 1:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 8:25 [PATCH] driver/rtc/class.c: check the error after rtc_read_time() Hyogi Gim
2014-07-23 21:56 ` Andrew Morton
2014-07-23 23:47 ` Rafael J. Wysocki
2014-07-23 23:49 ` Rafael J. Wysocki
2014-07-24 0:19 ` Andrew Morton
2014-08-07 1:58 ` Hyogi Gim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E2DD36.8000306@lge.com \
--to=hyogi.gim@lge.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rjw@sisk.pl \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox