From: Hyogi Gim <hyogi.gim@lge.com>
To: John Stultz <john.stultz@linaro.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Alessandro Zummo <a.zummo@towertech.it>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] alarmtimer: Add the verification code for rtc device error.
Date: Thu, 07 Aug 2014 11:00:28 +0900 [thread overview]
Message-ID: <53E2DDBC.1060603@lge.com> (raw)
In-Reply-To: <CALAqxLWcX9DV=1W7D9GNLz2UHvy7neFywuzpc32UfXTnNfvMmg@mail.gmail.com>
On 07/31/2014 02:58 AM, John Stultz wrote:
>
> Hey! Sorry for the late response here.
>
> So this seems reasonable as always failing suspend is problematic, but
> I worry that for the case where we do have a failure to read or set
> the RTC, we'd suspend and not wake up as specified, which is an issue
> as well. Absorbing the error silently in these cases would make it
> difficult to debug. Should we at least print some output out to help
> folks hunt down this sort of issue?
>
I agree. Most RTC device drivers don't print out the error of read_time.
So, I think the higher level like /drivers/rtc/interface.c should check
the error and give the information of the RTC device status.
I'll try to find a proper point.
prev parent reply other threads:[~2014-08-07 2:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 1:24 [PATCH] alarmtimer: Add the verification code for rtc device error Hyogi Gim
2014-07-30 17:58 ` John Stultz
2014-08-07 2:00 ` Hyogi Gim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E2DDBC.1060603@lge.com \
--to=hyogi.gim@lge.com \
--cc=a.zummo@towertech.it \
--cc=john.stultz@linaro.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox