From: Paolo Bonzini <pbonzini@redhat.com>
To: "Zhang, Yang Z" <yang.z.zhang@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] KVM: x86: always exit on EOIs for interrupts listed in the IOAPIC redir table
Date: Thu, 07 Aug 2014 08:13:24 +0200 [thread overview]
Message-ID: <53E31904.9040909@redhat.com> (raw)
In-Reply-To: <A9667DDFB95DB7438FA9D7D576C3D87E0AB5264D@SHSMSX104.ccr.corp.intel.com>
Il 07/08/2014 03:31, Zhang, Yang Z ha scritto:
> Let me give an example to see whether my concern is a real problem:
> Guest allocates a vector and set it in IOAPIC entry to deliver
> interrupt. Later it masks the IOAPIC entry(means stop the
> corresponding device) and assign this vector to a MSI device. With
> this patch, even the vector is not used by IOAPIC, but it still set
> eoi exit bitmap unconditionally. The subsequent EOIs to MSI device
> will force vmexit. Could this happen?
Yes, I guess it could. I'm not sure whether it could on Linux or Windows.
> I think the right fixing is to check the ISR plus TMR to construct
> the eoi exit bitmap.
Do you care enough to propose a patch? :)
Paolo
next prev parent reply other threads:[~2014-08-07 6:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 16:12 [PATCH] KVM: x86: always exit on EOIs for interrupts listed in the IOAPIC redir table Paolo Bonzini
2014-07-30 16:51 ` Alex Williamson
2014-08-06 14:03 ` Zhang, Yang Z
2014-08-06 14:08 ` Paolo Bonzini
2014-08-07 1:31 ` Zhang, Yang Z
2014-08-07 6:13 ` Paolo Bonzini [this message]
2014-08-07 6:17 ` Zhang, Yang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E31904.9040909@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox