* [PATCH] scsi: Check if WSR already defined
@ 2014-08-07 5:38 Nick Krause
2014-08-07 13:07 ` Hannes Reinecke
0 siblings, 1 reply; 2+ messages in thread
From: Nick Krause @ 2014-08-07 5:38 UTC (permalink / raw)
To: Matthew Wilcox, James E.J. Bottomley,
open list:LSILOGIC/SYMBIOS/..., open list
On xtensa arch there is this warning
drivers/scsi/sym53c8xx_2/sym_defs.h:109:0: warning: "WSR" redefined [enabled by default]
arch/xtensa/include/asm/processor.h:188:0: note: this is the location of the previous definition
I can remove WSR since it is not being used but more documentation purpose, so
undefining is enough.
Signed-off-by: Nick Krause <xerofoify@gmail.com>
---
drivers/scsi/sym53c8xx_2/sym_defs.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/scsi/sym53c8xx_2/sym_defs.h b/drivers/scsi/sym53c8xx_2/sym_defs.h
index defccc4..68334a5 100644
--- a/drivers/scsi/sym53c8xx_2/sym_defs.h
+++ b/drivers/scsi/sym53c8xx_2/sym_defs.h
@@ -91,6 +91,10 @@ struct sym_chip {
#define FE_CACHE0_SET (FE_CACHE_SET & ~FE_ERL)
};
+#ifdef WSR
+#undef WSR
+#endif
+
/*
* SYM53C8XX IO register data structure.
*/
--
2.0.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] scsi: Check if WSR already defined
2014-08-07 5:38 [PATCH] scsi: Check if WSR already defined Nick Krause
@ 2014-08-07 13:07 ` Hannes Reinecke
0 siblings, 0 replies; 2+ messages in thread
From: Hannes Reinecke @ 2014-08-07 13:07 UTC (permalink / raw)
To: Nick Krause, Matthew Wilcox, James E.J. Bottomley,
open list:LSILOGIC/SYMBIOS/..., open list
On 08/07/2014 07:38 AM, Nick Krause wrote:
> On xtensa arch there is this warning
>
> drivers/scsi/sym53c8xx_2/sym_defs.h:109:0: warning: "WSR" redefined [enabled by default]
> arch/xtensa/include/asm/processor.h:188:0: note: this is the location of the previous definition
>
> I can remove WSR since it is not being used but more documentation purpose, so
> undefining is enough.
>
> Signed-off-by: Nick Krause <xerofoify@gmail.com>
> ---
> drivers/scsi/sym53c8xx_2/sym_defs.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/scsi/sym53c8xx_2/sym_defs.h b/drivers/scsi/sym53c8xx_2/sym_defs.h
> index defccc4..68334a5 100644
> --- a/drivers/scsi/sym53c8xx_2/sym_defs.h
> +++ b/drivers/scsi/sym53c8xx_2/sym_defs.h
> @@ -91,6 +91,10 @@ struct sym_chip {
> #define FE_CACHE0_SET (FE_CACHE_SET & ~FE_ERL)
> };
>
> +#ifdef WSR
> +#undef WSR
> +#endif
> +
> /*
> * SYM53C8XX IO register data structure.
> */
>
Ouch.
Certainly not. Who knows for which odd function the 'WSR' definition
is used.
Better to redefine WSR in sym_defs.h.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-07 13:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-07 5:38 [PATCH] scsi: Check if WSR already defined Nick Krause
2014-08-07 13:07 ` Hannes Reinecke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox