From: Bart Van Assche <bvanassche@acm.org>
To: David Rientjes <rientjes@google.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] spin_lock_nested(): Always evaluate second argument
Date: Fri, 08 Aug 2014 12:32:29 +0200 [thread overview]
Message-ID: <53E4A73D.5080801@acm.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1408061455290.13545@chino.kir.corp.google.com>
On 08/06/14 23:56, David Rientjes wrote:
> On Wed, 6 Aug 2014, Bart Van Assche wrote:
>> diff --git a/include/linux/spinlock.h b/include/linux/spinlock.h
>> index 3f2867f..485d5dc 100644
>> --- a/include/linux/spinlock.h
>> +++ b/include/linux/spinlock.h
>> @@ -197,7 +197,8 @@ static inline void do_raw_spin_unlock(raw_spinlock_t *lock) __releases(lock)
>> _raw_spin_lock_nest_lock(lock, &(nest_lock)->dep_map); \
>> } while (0)
>> #else
>> -# define raw_spin_lock_nested(lock, subclass) _raw_spin_lock(lock)
>> +# define raw_spin_lock_nested(lock, subclass) \
>> + ((void)(subclass), _raw_spin_lock(lock))
>> # define raw_spin_lock_nest_lock(lock, nest_lock) _raw_spin_lock(lock)
>> #endif
>>
>
> I think it would be nice to comment why we're evaluating the subclass when
> CONFIG_DEBUG_LOCK_ALLOC=n so that nobody comes along and unknowingly
> changes it back.
>
> Thanks for posting the updated version and keeping at it!
This morning I received an e-mail from Wu Fengguang reporting that this
patch breaks the build for CONFIG_SMP=n. I will post a third version.
Bart.
next prev parent reply other threads:[~2014-08-08 10:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 7:17 [PATCH RESEND] spin_lock_*(): Always evaluate second argument Bart Van Assche
2014-07-22 20:37 ` Andrew Morton
2014-07-22 23:16 ` David Rientjes
2014-08-06 17:07 ` Bart Van Assche
2014-08-06 17:10 ` [PATCH v2] spin_lock_nested(): " Bart Van Assche
2014-08-06 21:56 ` David Rientjes
2014-08-08 10:32 ` Bart Van Assche [this message]
2014-08-08 10:35 ` [PATCH v3] " Bart Van Assche
2014-08-08 21:52 ` David Rientjes
2014-08-09 6:17 ` Peter Zijlstra
2014-08-13 10:56 ` [tip:locking/core] locking/spinlocks: Always evaluate the second argument of spin_lock_nested() tip-bot for Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E4A73D.5080801@acm.org \
--to=bvanassche@acm.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).