From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756763AbaHHOHl (ORCPT ); Fri, 8 Aug 2014 10:07:41 -0400 Received: from kdh-gw.itdev.co.uk ([89.21.227.133]:35208 "EHLO hermes.kdh.itdev.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756506AbaHHOHh (ORCPT ); Fri, 8 Aug 2014 10:07:37 -0400 Message-ID: <53E4D9A5.908@itdev.co.uk> Date: Fri, 08 Aug 2014 15:07:33 +0100 From: Nick Dyer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Javier Martinez Canillas , Dmitry Torokhov CC: Stephen Warren , Yufeng Shen , Benson Leung , Doug Anderson , Olof Johansson , Tomasz Figa , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] Input: atmel_mxt_ts - Get IRQ edge/level flags on DT booting References: <1407397492-17475-1-git-send-email-javier.martinez@collabora.co.uk> In-Reply-To: <1407397492-17475-1-git-send-email-javier.martinez@collabora.co.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/08/14 08:44, Javier Martinez Canillas wrote: > The Atmel maXTouch driver assumed that the IRQ type flags will > always be passed using platform data but this is not true when > booting using Device Trees. In these setups the interrupt type > was ignored by the driver when requesting an IRQ. > > This means that it will fail if a machine specified other type > than IRQ_TYPE_NONE. The right approach is to get the IRQ flags > that was parsed by OF from the "interrupt" Device Tree propery. > > Signed-off-by: Javier Martinez Canillas I'm happy for this to go in if Dmitry will accept it. It does seem to be a quirk of some platforms that it is necessary, but it's only one line. Thanks for spending so much time debugging this. Signed-off-by: Nick Dyer > --- > > This patch was first sent as a part of a two part series along > with [PATCH 2/2] Input: atmel_mxt_ts - Add keycodes array example. > > But there are no dependencies between these two patches so there > is no need to resend that one with no changes for v2. > > Changes since v1: > - Assign flags to pdata->irqflags in mxt_parse_dt() instead of probe(). > Suggested by Tomasz Figa. > > drivers/input/touchscreen/atmel_mxt_ts.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c > index 03b8571..5c8cbd3 100644 > --- a/drivers/input/touchscreen/atmel_mxt_ts.c > +++ b/drivers/input/touchscreen/atmel_mxt_ts.c > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -2093,6 +2094,8 @@ static struct mxt_platform_data *mxt_parse_dt(struct i2c_client *client) > if (!pdata) > return ERR_PTR(-ENOMEM); > > + pdata->irqflags = irq_get_trigger_type(client->irq); > + > if (of_find_property(client->dev.of_node, "linux,gpio-keymap", > &proplen)) { > pdata->t19_num_keys = proplen / sizeof(u32); >