From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Coccinelle <cocci@systeme.lip6.fr>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Fabian Frederick <fabf@skynet.be>, Joe Perches <joe@perches.com>
Subject: Re: [patch 119/197] scripts/coccinelle/free: Delete NULL test before freeing functions?
Date: Sat, 09 Aug 2014 11:13:58 +0200 [thread overview]
Message-ID: <53E5E656.1000606@users.sourceforge.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1408091028520.2016@localhost6.localdomain6>
> I still don't think this should be done for any random function that
> performs a null test on its argument. The corrections involved here are
> not as trivial as they would seem.
I would prefer to make the list of corresponding function names more complete.
> Often it is not the case that the null test at the call site should be
> just deleted, instead the code should be reorganized.
Which source code places do you know where a different approach might look better?
> (Personally, I don't like the whole null test removal idea. [...]
Would you like to clarify involved software concerns a bit more?
Regards,
Markus
next prev parent reply other threads:[~2014-08-09 9:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53e53fd1.zO3IbUqJ421c7VXf%akpm@linux-foundation.org>
2014-08-09 8:22 ` [patch 119/197] scripts/coccinelle/free: Delete NULL test before freeing functions SF Markus Elfring
2014-08-09 8:37 ` Julia Lawall
2014-08-09 9:13 ` SF Markus Elfring [this message]
2015-05-06 13:45 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E5E656.1000606@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=akpm@linux-foundation.org \
--cc=cocci@systeme.lip6.fr \
--cc=fabf@skynet.be \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).