From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751541AbaHJRqu (ORCPT ); Sun, 10 Aug 2014 13:46:50 -0400 Received: from mail.active-venture.com ([67.228.131.205]:55028 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbaHJRqs (ORCPT ); Sun, 10 Aug 2014 13:46:48 -0400 X-Originating-IP: 108.223.40.66 Message-ID: <53E7B006.9050605@roeck-us.net> Date: Sun, 10 Aug 2014 10:46:46 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Li Yang CC: "David S. Miller" , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, =?UTF-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= Subject: Re: [PATCH] net: ugg_geth: Fix build error in -next References: <1407687554-14539-1-git-send-email-linux@roeck-us.net> In-Reply-To: <1407687554-14539-1-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Grumble. Headline should be s/ugg/ucc, obviously. Guenter On 08/10/2014 09:19 AM, Guenter Roeck wrote: > powerpc:mpc83xx_defconfig and other builds fail with > > drivers/net/ethernet/freescale/ucc_geth.c: In function 'ucc_geth_remove': > drivers/net/ethernet/freescale/ucc_geth.c:3927:19: error: > 'struct ucc_geth_private' has no member named 'info' > of_node_put(ugeth->info->tbi_node); > ^ > drivers/net/ethernet/freescale/ucc_geth.c:3928:19: error: > 'struct ucc_geth_private' has no member named 'info' > of_node_put(ugeth->info->phy_node); > ^ > > Introduced by commit "net: ucc_geth: drop acquired references in probe error > path and remove". > >>>From the context, it appears that the variable is named ug_info. > > Cc: Uwe Kleine-König > Signed-off-by: Guenter Roeck > --- > Only seen in -next. > > drivers/net/ethernet/freescale/ucc_geth.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c > index d6b64e3..3cf0478 100644 > --- a/drivers/net/ethernet/freescale/ucc_geth.c > +++ b/drivers/net/ethernet/freescale/ucc_geth.c > @@ -3924,8 +3924,8 @@ static int ucc_geth_remove(struct platform_device* ofdev) > unregister_netdev(dev); > free_netdev(dev); > ucc_geth_memclean(ugeth); > - of_node_put(ugeth->info->tbi_node); > - of_node_put(ugeth->info->phy_node); > + of_node_put(ugeth->ug_info->tbi_node); > + of_node_put(ugeth->ug_info->phy_node); > > return 0; > } >