public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Vivek Goyal <vgoyal@redhat.com>,
	linux kernel mailing list <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: "Daniel Walter" <sahne@0x90.at>,
	"Toralf Förster" <toralf.foerster@gmx.de>,
	user-mode-linux-devel
	<user-mode-linux-devel@lists.sourceforge.net>
Subject: Re: [PATCH] resource: Fix the case of null pointer access
Date: Tue, 12 Aug 2014 16:49:35 +0200	[thread overview]
Message-ID: <53EA297F.1040107@nod.at> (raw)
In-Reply-To: <20140812144655.GB16961@redhat.com>

Am 12.08.2014 16:46, schrieb Vivek Goyal:
> Richard and Daniel reported that UML is broken due to changes to resource
> traversal functions. Problem is that iomem_resource.child can be null
> and new code does not consider that possibility. Old code used a for loop
> and that loop will not even execute if p was null.
> 
> Revert back to for() loop logic and bail out if p is null.
> 
> I also moved sibling_only check out of resource_lock. There is no
> reason to keep it inside the lock.
> 
> Following is backtrace of the UML crash.

Shall I pickup this patch and route it via my uml tree to Linus?

Thanks,
//richard

  reply	other threads:[~2014-08-12 14:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-12 14:46 [PATCH] resource: Fix the case of null pointer access Vivek Goyal
2014-08-12 14:49 ` Richard Weinberger [this message]
2014-08-12 15:04   ` Vivek Goyal
2014-08-12 17:38     ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53EA297F.1040107@nod.at \
    --to=richard@nod.at \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sahne@0x90.at \
    --cc=toralf.foerster@gmx.de \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox