From: Stephen Warren <swarren@wwwdotorg.org>
To: Nick Dyer <nick.dyer@itdev.co.uk>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, Yufeng Shen <miletus@chromium.org>,
Benson Leung <bleung@chromium.org>,
Stephen Warren <swarren@nvidia.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: atmel_mxt_ts - fix a few issues reported by Coverity
Date: Tue, 12 Aug 2014 10:41:08 -0600 [thread overview]
Message-ID: <53EA43A4.2070301@wwwdotorg.org> (raw)
In-Reply-To: <53EA431F.6020908@itdev.co.uk>
On 08/12/2014 10:38 AM, Nick Dyer wrote:
> On 11/08/14 19:03, Dmitry Torokhov wrote:
>> This should fix the following issues reported by Coverity:
>>
>> *** CID 1230625: Logically dead code (DEADCODE)
>> /drivers/input/touchscreen/atmel_mxt_ts.c: 1692 in mxt_initialize()
>>
>> *** CID 1230627: Missing break in switch (MISSING_BREAK)
>> /drivers/input/touchscreen/atmel_mxt_ts.c: 1436 in mxt_get_object_table()
>>
>> *** CID 1230629: Out-of-bounds write (OVERRUN)
>> /drivers/input/touchscreen/atmel_mxt_ts.c: 1267 in mxt_update_cfg()
>>
>> *** CID 1230632: Unused pointer value (UNUSED_VALUE)
>> /drivers/input/touchscreen/atmel_mxt_ts.c: 1211 in mxt_update_cfg()
>>
>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> I've reviewed these changes and they look correct to me. Apologies that
> they slipped through, most of it is bad merging on my part I think.
>
> Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk>
Don't you mean Acked-by or Reviewed-by?
next prev parent reply other threads:[~2014-08-12 16:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 18:03 [PATCH] Input: atmel_mxt_ts - fix a few issues reported by Coverity Dmitry Torokhov
2014-08-12 16:38 ` Nick Dyer
2014-08-12 16:41 ` Stephen Warren [this message]
2014-08-12 21:08 ` Nick Dyer
2014-08-13 16:14 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EA43A4.2070301@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=bleung@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miletus@chromium.org \
--cc=nick.dyer@itdev.co.uk \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox